[3/4] xfs/045: can't change UUID on v5 filesystems.
diff mbox

Message ID 20150505005112.GK15810@dastard
State New
Headers show

Commit Message

Dave Chinner May 5, 2015, 12:51 a.m. UTC
On Mon, May 04, 2015 at 05:48:31PM -0500, Eric Sandeen wrote:
> On 5/4/15 5:01 PM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> > 
> > So pass "-m crc=0" to the scratch_mkfs command so that we only run
> > on old v4 format filesystems where the UUID can be changed.
> > 
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> 
> hm, given that I might "fix" this should we instead trap
> on an xfs_db uuid failure, and _notrun the test?
> (oh, but older xfs_db let it go, didn't it.  sigh).
> 
> I guess nothing about the presence of crc vs. non-crc
> matters for this test, so turning it off by default is probably ok.
> It could use a comment about why it's got "-m crc=0" though, at
> least.

Added. New patch below.

Comments

Eric Sandeen May 5, 2015, 2:04 a.m. UTC | #1
On 5/4/15 7:51 PM, Dave Chinner wrote:
> On Mon, May 04, 2015 at 05:48:31PM -0500, Eric Sandeen wrote:
>> On 5/4/15 5:01 PM, Dave Chinner wrote:
>>> From: Dave Chinner <dchinner@redhat.com>
>>>
>>> So pass "-m crc=0" to the scratch_mkfs command so that we only run
>>> on old v4 format filesystems where the UUID can be changed.
>>>
>>> Signed-off-by: Dave Chinner <dchinner@redhat.com>
>>
>> hm, given that I might "fix" this should we instead trap
>> on an xfs_db uuid failure, and _notrun the test?
>> (oh, but older xfs_db let it go, didn't it.  sigh).
>>
>> I guess nothing about the presence of crc vs. non-crc
>> matters for this test, so turning it off by default is probably ok.
>> It could use a comment about why it's got "-m crc=0" though, at
>> least.
> 
> Added. New patch below.
> 

Thanks.

Reviewed-by: Eric Sandeen <sandeen@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/tests/xfs/045 b/tests/xfs/045
index 7d8a4a1..2733f5c 100755
--- a/tests/xfs/045
+++ b/tests/xfs/045
@@ -49,8 +49,11 @@  _require_scratch_nocheck
 
 echo "*** get uuid"
 uuid=`_get_existing_uuid`
+
+# We can only change the UUID on a v4 filesystem. Revist this when/if UUIDs
+# can be changed on v5 filesystems.
 echo "*** mkfs"
-if ! _scratch_mkfs_xfs >$tmp.out 2>&1
+if ! _scratch_mkfs_xfs -m crc=0 >$tmp.out 2>&1
 then
     cat $tmp.out
     echo "!!! failed to mkfs on $SCRATCH_DEV"