ARM: dts: cros-ec-keyboard: Add support for some Japanese keys
diff mbox

Message ID 1430791657-28014-1-git-send-email-zyw@rock-chips.com
State New
Headers show

Commit Message

Chris Zhong May 5, 2015, 2:07 a.m. UTC
Add support for 4 Japanese keys

Signed-off-by: Chris Zhong <zyw@rock-chips.com>

---

 arch/arm/boot/dts/cros-ec-keyboard.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Douglas Anderson May 5, 2015, 6:10 p.m. UTC | #1
Chris,

On Mon, May 4, 2015 at 7:07 PM, Chris Zhong <zyw@rock-chips.com> wrote:
> Add support for 4 Japanese keys
>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>
> ---
>
>  arch/arm/boot/dts/cros-ec-keyboard.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> index 9c7fb0a..4e42f30c 100644
> --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> @@ -22,6 +22,7 @@
>                         MATRIX_KEY(0x00, 0x02, KEY_F1)
>                         MATRIX_KEY(0x00, 0x03, KEY_B)
>                         MATRIX_KEY(0x00, 0x04, KEY_F10)
> +                       MATRIX_KEY(0x00, 0x05, KEY_RO)
>                         MATRIX_KEY(0x00, 0x06, KEY_N)
>                         MATRIX_KEY(0x00, 0x08, KEY_EQUAL)
>                         MATRIX_KEY(0x00, 0x0a, KEY_RIGHTALT)
> @@ -34,6 +35,7 @@
>                         MATRIX_KEY(0x01, 0x08, KEY_APOSTROPHE)
>                         MATRIX_KEY(0x01, 0x09, KEY_F9)
>                         MATRIX_KEY(0x01, 0x0b, KEY_BACKSPACE)
> +                       MATRIX_KEY(0x01, 0x0c, KEY_HENKAN)
>
>                         MATRIX_KEY(0x02, 0x00, KEY_LEFTCTRL)
>                         MATRIX_KEY(0x02, 0x01, KEY_TAB)
> @@ -45,6 +47,7 @@
>                         MATRIX_KEY(0x02, 0x07, KEY_102ND)
>                         MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
>                         MATRIX_KEY(0x02, 0x09, KEY_F8)
> +                       MATRIX_KEY(0x02, 0x0a, KEY_YEN)
>
>                         MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
>                         MATRIX_KEY(0x03, 0x02, KEY_F2)
> @@ -53,6 +56,7 @@
>                         MATRIX_KEY(0x03, 0x06, KEY_6)
>                         MATRIX_KEY(0x03, 0x08, KEY_MINUS)
>                         MATRIX_KEY(0x03, 0x0b, KEY_BACKSLASH)
> +                       MATRIX_KEY(0x03, 0x0c, KEY_MUHENKAN)
>
>                         MATRIX_KEY(0x04, 0x00, KEY_RIGHTCTRL)
>                         MATRIX_KEY(0x04, 0x01, KEY_A)

Since there's no clear architecture here, I'd bet Olof would be the
one to take this.  I added him to this email, but he might request
that you resend the patch with him in the "To:" line.

Other than that:

Reviewed-by: Doug Anderson <dianders@chromium.org>
Chris Zhong May 6, 2015, 12:59 a.m. UTC | #2
On 05/06/2015 02:10 AM, Doug Anderson wrote:
> Chris,
>
> On Mon, May 4, 2015 at 7:07 PM, Chris Zhong <zyw@rock-chips.com> wrote:
>> Add support for 4 Japanese keys
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>>
>> ---
>>
>>   arch/arm/boot/dts/cros-ec-keyboard.dtsi | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> index 9c7fb0a..4e42f30c 100644
>> --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> @@ -22,6 +22,7 @@
>>                          MATRIX_KEY(0x00, 0x02, KEY_F1)
>>                          MATRIX_KEY(0x00, 0x03, KEY_B)
>>                          MATRIX_KEY(0x00, 0x04, KEY_F10)
>> +                       MATRIX_KEY(0x00, 0x05, KEY_RO)
>>                          MATRIX_KEY(0x00, 0x06, KEY_N)
>>                          MATRIX_KEY(0x00, 0x08, KEY_EQUAL)
>>                          MATRIX_KEY(0x00, 0x0a, KEY_RIGHTALT)
>> @@ -34,6 +35,7 @@
>>                          MATRIX_KEY(0x01, 0x08, KEY_APOSTROPHE)
>>                          MATRIX_KEY(0x01, 0x09, KEY_F9)
>>                          MATRIX_KEY(0x01, 0x0b, KEY_BACKSPACE)
>> +                       MATRIX_KEY(0x01, 0x0c, KEY_HENKAN)
>>
>>                          MATRIX_KEY(0x02, 0x00, KEY_LEFTCTRL)
>>                          MATRIX_KEY(0x02, 0x01, KEY_TAB)
>> @@ -45,6 +47,7 @@
>>                          MATRIX_KEY(0x02, 0x07, KEY_102ND)
>>                          MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
>>                          MATRIX_KEY(0x02, 0x09, KEY_F8)
>> +                       MATRIX_KEY(0x02, 0x0a, KEY_YEN)
>>
>>                          MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
>>                          MATRIX_KEY(0x03, 0x02, KEY_F2)
>> @@ -53,6 +56,7 @@
>>                          MATRIX_KEY(0x03, 0x06, KEY_6)
>>                          MATRIX_KEY(0x03, 0x08, KEY_MINUS)
>>                          MATRIX_KEY(0x03, 0x0b, KEY_BACKSLASH)
>> +                       MATRIX_KEY(0x03, 0x0c, KEY_MUHENKAN)
>>
>>                          MATRIX_KEY(0x04, 0x00, KEY_RIGHTCTRL)
>>                          MATRIX_KEY(0x04, 0x01, KEY_A)
> Since there's no clear architecture here, I'd bet Olof would be the
> one to take this.  I added him to this email, but he might request
> that you resend the patch with him in the "To:" line.
>
> Other than that:
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
>
Thank you, I'll resend the patch with Olof.
>
Olof Johansson July 13, 2015, 9:47 p.m. UTC | #3
On Tue, May 05, 2015 at 11:10:42AM -0700, Doug Anderson wrote:
> Chris,
> 
> Since there's no clear architecture here, I'd bet Olof would be the
> one to take this.  I added him to this email, but he might request
> that you resend the patch with him in the "To:" line.
> 
> Other than that:
> 
> Reviewed-by: Doug Anderson <dianders@chromium.org>

Very belatedly applied for 4.2 fixes.


-Olof

Patch
diff mbox

diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
index 9c7fb0a..4e42f30c 100644
--- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
+++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
@@ -22,6 +22,7 @@ 
 			MATRIX_KEY(0x00, 0x02, KEY_F1)
 			MATRIX_KEY(0x00, 0x03, KEY_B)
 			MATRIX_KEY(0x00, 0x04, KEY_F10)
+			MATRIX_KEY(0x00, 0x05, KEY_RO)
 			MATRIX_KEY(0x00, 0x06, KEY_N)
 			MATRIX_KEY(0x00, 0x08, KEY_EQUAL)
 			MATRIX_KEY(0x00, 0x0a, KEY_RIGHTALT)
@@ -34,6 +35,7 @@ 
 			MATRIX_KEY(0x01, 0x08, KEY_APOSTROPHE)
 			MATRIX_KEY(0x01, 0x09, KEY_F9)
 			MATRIX_KEY(0x01, 0x0b, KEY_BACKSPACE)
+			MATRIX_KEY(0x01, 0x0c, KEY_HENKAN)
 
 			MATRIX_KEY(0x02, 0x00, KEY_LEFTCTRL)
 			MATRIX_KEY(0x02, 0x01, KEY_TAB)
@@ -45,6 +47,7 @@ 
 			MATRIX_KEY(0x02, 0x07, KEY_102ND)
 			MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
 			MATRIX_KEY(0x02, 0x09, KEY_F8)
+			MATRIX_KEY(0x02, 0x0a, KEY_YEN)
 
 			MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
 			MATRIX_KEY(0x03, 0x02, KEY_F2)
@@ -53,6 +56,7 @@ 
 			MATRIX_KEY(0x03, 0x06, KEY_6)
 			MATRIX_KEY(0x03, 0x08, KEY_MINUS)
 			MATRIX_KEY(0x03, 0x0b, KEY_BACKSLASH)
+			MATRIX_KEY(0x03, 0x0c, KEY_MUHENKAN)
 
 			MATRIX_KEY(0x04, 0x00, KEY_RIGHTCTRL)
 			MATRIX_KEY(0x04, 0x01, KEY_A)