[1/6] ALSA: hda/tegra - Set CORBRP self-clear flag
diff mbox

Message ID 1430830584-3113-1-git-send-email-thierry.reding@gmail.com
State New
Headers show

Commit Message

Thierry Reding May 5, 2015, 12:56 p.m. UTC
From: Thierry Reding <treding@nvidia.com>

This is set for the MCP variants of the NVIDIA HDA controller, which the
Tegra variant was derived from. This fixes the following warning at boot
time:

	[    2.486610] tegra-hda 70030000.hda: CORB reset timeout#1, CORBRP = 0

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 sound/pci/hda/hda_tegra.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Takashi Iwai May 9, 2015, 5:58 a.m. UTC | #1
At Tue,  5 May 2015 14:56:19 +0200,
Thierry Reding wrote:
> 
> From: Thierry Reding <treding@nvidia.com>
> 
> This is set for the MCP variants of the NVIDIA HDA controller, which the
> Tegra variant was derived from. This fixes the following warning at boot
> time:
> 
> 	[    2.486610] tegra-hda 70030000.hda: CORB reset timeout#1, CORBRP = 0
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Since I've been traveling in this and next weeks, I'll check and apply
this series after my vacation although they look good at a quick
glance.


thanks,

Takashi

> ---
>  sound/pci/hda/hda_tegra.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
> index db0bb50fa5b9..7003677f7473 100644
> --- a/sound/pci/hda/hda_tegra.c
> +++ b/sound/pci/hda/hda_tegra.c
> @@ -460,11 +460,12 @@ MODULE_DEVICE_TABLE(of, hda_tegra_match);
>  
>  static int hda_tegra_probe(struct platform_device *pdev)
>  {
> +	const unsigned int driver_flags = AZX_DCAPS_RIRB_DELAY |
> +					  AZX_DCAPS_CORBRP_SELF_CLEAR;
>  	struct snd_card *card;
>  	struct azx *chip;
>  	struct hda_tegra *hda;
>  	int err;
> -	const unsigned int driver_flags = AZX_DCAPS_RIRB_DELAY;
>  
>  	hda = devm_kzalloc(&pdev->dev, sizeof(*hda), GFP_KERNEL);
>  	if (!hda)
> -- 
> 2.3.5
>
Takashi Iwai May 18, 2015, 8:04 a.m. UTC | #2
At Tue,  5 May 2015 14:56:19 +0200,
Thierry Reding wrote:
> 
> From: Thierry Reding <treding@nvidia.com>
> 
> This is set for the MCP variants of the NVIDIA HDA controller, which the
> Tegra variant was derived from. This fixes the following warning at boot
> time:
> 
> 	[    2.486610] tegra-hda 70030000.hda: CORB reset timeout#1, CORBRP = 0
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Applied all six patches now.  Thanks.


Takashi

> ---
>  sound/pci/hda/hda_tegra.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
> index db0bb50fa5b9..7003677f7473 100644
> --- a/sound/pci/hda/hda_tegra.c
> +++ b/sound/pci/hda/hda_tegra.c
> @@ -460,11 +460,12 @@ MODULE_DEVICE_TABLE(of, hda_tegra_match);
>  
>  static int hda_tegra_probe(struct platform_device *pdev)
>  {
> +	const unsigned int driver_flags = AZX_DCAPS_RIRB_DELAY |
> +					  AZX_DCAPS_CORBRP_SELF_CLEAR;
>  	struct snd_card *card;
>  	struct azx *chip;
>  	struct hda_tegra *hda;
>  	int err;
> -	const unsigned int driver_flags = AZX_DCAPS_RIRB_DELAY;
>  
>  	hda = devm_kzalloc(&pdev->dev, sizeof(*hda), GFP_KERNEL);
>  	if (!hda)
> -- 
> 2.3.5
>

Patch
diff mbox

diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
index db0bb50fa5b9..7003677f7473 100644
--- a/sound/pci/hda/hda_tegra.c
+++ b/sound/pci/hda/hda_tegra.c
@@ -460,11 +460,12 @@  MODULE_DEVICE_TABLE(of, hda_tegra_match);
 
 static int hda_tegra_probe(struct platform_device *pdev)
 {
+	const unsigned int driver_flags = AZX_DCAPS_RIRB_DELAY |
+					  AZX_DCAPS_CORBRP_SELF_CLEAR;
 	struct snd_card *card;
 	struct azx *chip;
 	struct hda_tegra *hda;
 	int err;
-	const unsigned int driver_flags = AZX_DCAPS_RIRB_DELAY;
 
 	hda = devm_kzalloc(&pdev->dev, sizeof(*hda), GFP_KERNEL);
 	if (!hda)