[V4,3/5] ASoC: tas571x: Add DT binding document
diff mbox

Message ID 1430864057-3848-4-git-send-email-cernekee@chromium.org
State New
Headers show

Commit Message

Kevin Cernekee May 5, 2015, 10:14 p.m. UTC
Document the bindings for the soon-to-be-added tas571x driver.

Signed-off-by: Kevin Cernekee <cernekee@chromium.org>
---
 .../devicetree/bindings/sound/tas571x.txt          | 41 ++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/tas571x.txt

Comments

Mark Brown May 5, 2015, 10:32 p.m. UTC | #1
On Tue, May 05, 2015 at 03:14:15PM -0700, Kevin Cernekee wrote:
> Document the bindings for the soon-to-be-added tas571x driver.

If this is different to the already applied patches send incremental
updates.  If this is the same as the version of the driver that is
already applied please don't resend already applied patches.
Kevin Cernekee May 5, 2015, 10:56 p.m. UTC | #2
On Tue, May 5, 2015 at 3:32 PM, Mark Brown <broonie@kernel.org> wrote:
> On Tue, May 05, 2015 at 03:14:15PM -0700, Kevin Cernekee wrote:
>> Document the bindings for the soon-to-be-added tas571x driver.
>
> If this is different to the already applied patches send incremental
> updates.  If this is the same as the version of the driver that is
> already applied please don't resend already applied patches.

OK - I sent an incremental update for the one thing that changed in
the tas571x driver from V3 to V4.

Note that the regcache changes were intentionally ordered before the
tas571x commits, because the regcache changes are needed for the new
driver to work correctly.  In the for-next branch I see the tas571x
commits, but not the regcache changes.
Mark Brown May 5, 2015, 11:01 p.m. UTC | #3
On Tue, May 05, 2015 at 03:56:09PM -0700, Kevin Cernekee wrote:

> Note that the regcache changes were intentionally ordered before the
> tas571x commits, because the regcache changes are needed for the new
> driver to work correctly.  In the for-next branch I see the tas571x
> commits, but not the regcache changes.

That's fine, there's no actual code dependency and the regmap git tree
is separate to the ASoC git tree.  It's not like there's an existing
driver we'd be breaking the bisection for.

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/sound/tas571x.txt b/Documentation/devicetree/bindings/sound/tas571x.txt
new file mode 100644
index 000000000000..0ac31d8d5ac4
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/tas571x.txt
@@ -0,0 +1,41 @@ 
+Texas Instruments TAS5711/TAS5717/TAS5719 stereo power amplifiers
+
+The codec is controlled through an I2C interface.  It also has two other
+signals that can be wired up to GPIOs: reset (strongly recommended), and
+powerdown (optional).
+
+Required properties:
+
+- compatible: "ti,tas5711", "ti,tas5717", or "ti,tas5719"
+- reg: The I2C address of the device
+- #sound-dai-cells: must be equal to 0
+
+Optional properties:
+
+- reset-gpios: GPIO specifier for the TAS571x's active low reset line
+- pdn-gpios: GPIO specifier for the TAS571x's active low powerdown line
+- clocks: clock phandle for the MCLK input
+- clock-names: should be "mclk"
+- AVDD-supply: regulator phandle for the AVDD supply (all chips)
+- DVDD-supply: regulator phandle for the DVDD supply (all chips)
+- HPVDD-supply: regulator phandle for the HPVDD supply (5717/5719)
+- PVDD_AB-supply: regulator phandle for the PVDD_AB supply (5717/5719)
+- PVDD_CD-supply: regulator phandle for the PVDD_CD supply (5717/5719)
+- PVDD_A-supply: regulator phandle for the PVDD_A supply (5711)
+- PVDD_B-supply: regulator phandle for the PVDD_B supply (5711)
+- PVDD_C-supply: regulator phandle for the PVDD_C supply (5711)
+- PVDD_D-supply: regulator phandle for the PVDD_D supply (5711)
+
+Example:
+
+	tas5717: audio-codec@2a {
+		compatible = "ti,tas5717";
+		reg = <0x2a>;
+		#sound-dai-cells = <0>;
+
+		reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>;
+		pdn-gpios = <&gpio5 2 GPIO_ACTIVE_LOW>;
+
+		clocks = <&clk_core CLK_I2S>;
+		clock-names = "mclk";
+	};