drm/i915: Demote hangcheck ring idle warning
diff mbox

Message ID 1430905240-24235-1-git-send-email-mika.kuoppala@intel.com
State New
Headers show

Commit Message

Mika Kuoppala May 6, 2015, 9:40 a.m. UTC
Currently we have race between request->list addition
and hangcheck inspecting that list. It leads to hangcheck
concluding that ring is idle, even if its not.

Demote the error to a info message until the issue with
race is fixed.

References: https://bugs.freedesktop.org/show_bug.cgi?id=89493
References: http://lists.freedesktop.org/archives/intel-gfx/2015-February/060545.html
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chris Wilson May 6, 2015, 10:12 a.m. UTC | #1
On Wed, May 06, 2015 at 12:40:40PM +0300, Mika Kuoppala wrote:
> Currently we have race between request->list addition
> and hangcheck inspecting that list. It leads to hangcheck
> concluding that ring is idle, even if its not.
> 
> Demote the error to a info message until the issue with
> race is fixed.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=89493
> References: http://lists.freedesktop.org/archives/intel-gfx/2015-February/060545.html
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>

Should be KERN_NOTICE. In the real case at least, it is an error, but we
have an adequate workaround.
-Chris
Shuang He May 7, 2015, 8:13 a.m. UTC | #2
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6325
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                                  276/276              276/276
ILK                                  302/302              302/302
SNB                                  316/316              316/316
IVB                                  342/342              342/342
BYT                                  286/286              286/286
BDW                                  321/321              321/321
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
Note: You need to pay more attention to line start with '*'

Patch
diff mbox

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 9da955e..b0fec20 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2925,8 +2925,8 @@  static void i915_hangcheck_elapsed(struct work_struct *work)
 					/* Issue a wake-up to catch stuck h/w. */
 					if (!test_and_set_bit(ring->id, &dev_priv->gpu_error.missed_irq_rings)) {
 						if (!(dev_priv->gpu_error.test_irq_rings & intel_ring_flag(ring)))
-							DRM_ERROR("Hangcheck timer elapsed... %s idle\n",
-								  ring->name);
+							DRM_INFO("Hangcheck timer elapsed... %s idle\n",
+								 ring->name);
 						else
 							DRM_INFO("Fake missed irq on %s\n",
 								 ring->name);