diff mbox

[2/2,linux-next] drm/msm: use IS_ERR() to check regulator_get() return

Message ID 1430759036-17827-2-git-send-email-fabf@skynet.be (mailing list archive)
State Accepted
Headers show

Commit Message

Fabian Frederick May 4, 2015, 5:03 p.m. UTC 
regulator_get() never returns NULL. There's no need for IS_ERR_OR_NULL()

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabian Frederick May 6, 2015, 5:37 p.m. UTC | #1 
Please ignore this patch, I just noticed conditional regulator_get()
definition (#if defined(CONFIG_REGULATOR))

Regards,
Fabian
diff mbox

Patch

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 956b224..642cbaf 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -273,7 +273,7 @@  static const struct dsi_config *dsi_get_config(struct msm_dsi_host *msm_host)
 	u32 major = 0, minor = 0;
 
 	gdsc_reg = regulator_get(&msm_host->pdev->dev, "gdsc");
-	if (IS_ERR_OR_NULL(gdsc_reg)) {
+	if (IS_ERR(gdsc_reg)) {
 		pr_err("%s: cannot get gdsc\n", __func__);
 		goto fail;
 	}