| Message ID | 1430993786-32064-1-git-send-email-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 07 May 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote: > Since the introduction of BIOS fb preservation, circa 3.17, we began > encountering a failure during boot when trying to use force-detect > before GEM was initialised. That bug is from > > commit 7fad798e16fecddd41c6a91728a09f0b9507e40c > Author: Daniel Vetter <daniel.vetter@ffwll.ch> > Date: Wed Jul 4 17:51:47 2012 +0200 > > drm/i915: ensure the force pipe A quirk is actually followed > > but investigation of the affected machine revealed that it was using a > PIPE-A quirk even though it was a 945GSE and the quirk is only supposed > to be used to workaround a hardware issue on 830/845. That quirk was > added for this HP Mini in > > commit 6b93afc564a5e74b0eaaa46c95f557449951b3b9 > Author: Bryce Harrington <bryce@bryceharrington.org> > Date: Wed May 27 03:40:52 2009 -0700 > > add pipe a force quirk for Dell mini > > in order to workaround an issue with the BIOS behaving strangely during > lid-close. Since then we have a much larger hammer to thwart the BIOS > after opening the lid and the PIPE-A quirk is no longer required. > > Reported-any-tested-by: Apostolos B. > References: https://bugs.freedesktop.org/show_bug.cgi?id=21960 > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=87521#c13 > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Pushed to drm-intel-fixes, thanks for the patch. BR, Jani. > --- > drivers/gpu/drm/i915/intel_display.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 77929538ec0a..8de94e8dcecc 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -14542,9 +14542,6 @@ static const struct intel_dmi_quirk intel_dmi_quirks[] = { > }; > > static struct intel_quirk intel_quirks[] = { > - /* HP Mini needs pipe A force quirk (LP: #322104) */ > - { 0x27ae, 0x103c, 0x361a, quirk_pipea_force }, > - > /* Toshiba Protege R-205, S-209 needs pipe A force quirk */ > { 0x2592, 0x1179, 0x0001, quirk_pipea_force }, > > -- > 2.1.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6342
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 276/276 276/276
ILK 302/302 302/302
SNB 316/316 316/316
IVB 342/342 342/342
BYT 286/286 286/286
BDW 321/321 321/321
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 77929538ec0a..8de94e8dcecc 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -14542,9 +14542,6 @@ static const struct intel_dmi_quirk intel_dmi_quirks[] = { }; static struct intel_quirk intel_quirks[] = { - /* HP Mini needs pipe A force quirk (LP: #322104) */ - { 0x27ae, 0x103c, 0x361a, quirk_pipea_force }, - /* Toshiba Protege R-205, S-209 needs pipe A force quirk */ { 0x2592, 0x1179, 0x0001, quirk_pipea_force },
Since the introduction of BIOS fb preservation, circa 3.17, we began encountering a failure during boot when trying to use force-detect before GEM was initialised. That bug is from commit 7fad798e16fecddd41c6a91728a09f0b9507e40c Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Wed Jul 4 17:51:47 2012 +0200 drm/i915: ensure the force pipe A quirk is actually followed but investigation of the affected machine revealed that it was using a PIPE-A quirk even though it was a 945GSE and the quirk is only supposed to be used to workaround a hardware issue on 830/845. That quirk was added for this HP Mini in commit 6b93afc564a5e74b0eaaa46c95f557449951b3b9 Author: Bryce Harrington <bryce@bryceharrington.org> Date: Wed May 27 03:40:52 2009 -0700 add pipe a force quirk for Dell mini in order to workaround an issue with the BIOS behaving strangely during lid-close. Since then we have a much larger hammer to thwart the BIOS after opening the lid and the PIPE-A quirk is no longer required. Reported-any-tested-by: Apostolos B. References: https://bugs.freedesktop.org/show_bug.cgi?id=21960 Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=87521#c13 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/intel_display.c | 3 --- 1 file changed, 3 deletions(-)