_require_command: fixed typo
diff mbox

Message ID 1431014916-1951-1-git-send-email-omzg@plexistor.com
State New
Headers show

Commit Message

Omer Zilberberg May 7, 2015, 4:08 p.m. UTC
fixes 9435b92 common: _require_command needs to handle parameters

Signed-off-by: Omer Zilberberg <omzg@plexistor.com>
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Sandeen May 7, 2015, 4:09 p.m. UTC | #1
On 5/7/15 11:08 AM, Omer Zilberberg wrote:
> fixes 9435b92 common: _require_command needs to handle parameters
> 
> Signed-off-by: Omer Zilberberg <omzg@plexistor.com>

Yep, thanks!

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  common/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index 6ea107e..cd0f3e6 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1299,7 +1299,7 @@ _require_command()
>  	fi
>  
>  	_command=`echo "$1" | awk '{ print $1 }'`
> -	if [ ! -x $command ]; then
> +	if [ ! -x $_command ]; then
>  		_notrun "$_name utility required, skipped this test"
>  	fi
>  }
> 

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eryu Guan May 18, 2015, 8:16 a.m. UTC | #2
On Thu, May 07, 2015 at 07:08:36PM +0300, Omer Zilberberg wrote:
> fixes 9435b92 common: _require_command needs to handle parameters
> 
> Signed-off-by: Omer Zilberberg <omzg@plexistor.com>
> ---
>  common/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index 6ea107e..cd0f3e6 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1299,7 +1299,7 @@ _require_command()
>  	fi
>  
>  	_command=`echo "$1" | awk '{ print $1 }'`
> -	if [ ! -x $command ]; then
> +	if [ ! -x $_command ]; then

Can you please send v2 with $_command quoted? I found that if $_command
is empty -x still treats it as executable, but not empty quoted string.

# prints ok
if [ -x ]; then echo ok; fi

# prints nothing
if [ -x "" ]; then echo ok; fi

Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/common/rc b/common/rc
index 6ea107e..cd0f3e6 100644
--- a/common/rc
+++ b/common/rc
@@ -1299,7 +1299,7 @@  _require_command()
 	fi
 
 	_command=`echo "$1" | awk '{ print $1 }'`
-	if [ ! -x $command ]; then
+	if [ ! -x $_command ]; then
 		_notrun "$_name utility required, skipped this test"
 	fi
 }