[v2,2/2] ASoC: sta350: Use devm_gpiod_get_optional at appropriate place
diff mbox

Message ID 1431184172.5393.2.camel@ingics.com
State New
Headers show

Commit Message

Axel Lin May 9, 2015, 3:09 p.m. UTC
devm_gpiod_get_optional is equivalent to devm_gpiod_get(), except that
when no GPIO was assigned to the requested function it will return NULL.
This is convenient for drivers that need to handle optional GPIOs.

I just checked the code in commit 34d7c3905adb9a9
("ASoC: improve usage of gpiod API") and found that it should use
devm_gpiod_get_optional rather than devm_gpiod_get here.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
v2: Fixup subject line

 sound/soc/codecs/sta350.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mark Brown May 12, 2015, 5:52 p.m. UTC | #1
On Sat, May 09, 2015 at 11:09:32PM +0800, Axel Lin wrote:
> devm_gpiod_get_optional is equivalent to devm_gpiod_get(), except that
> when no GPIO was assigned to the requested function it will return NULL.
> This is convenient for drivers that need to handle optional GPIOs.

Applied, thanks.

Patch
diff mbox

diff --git a/sound/soc/codecs/sta350.c b/sound/soc/codecs/sta350.c
index 50d8bbf..0cea8f9 100644
--- a/sound/soc/codecs/sta350.c
+++ b/sound/soc/codecs/sta350.c
@@ -1217,8 +1217,8 @@  static int sta350_i2c_probe(struct i2c_client *i2c,
 	if (IS_ERR(sta350->gpiod_nreset))
 		return PTR_ERR(sta350->gpiod_nreset);
 
-	sta350->gpiod_power_down = devm_gpiod_get(dev, "power-down",
-						  GPIOD_OUT_LOW);
+	sta350->gpiod_power_down = devm_gpiod_get_optional(dev, "power-down",
+							   GPIOD_OUT_LOW);
 	if (IS_ERR(sta350->gpiod_power_down))
 		return PTR_ERR(sta350->gpiod_power_down);