[1/2] drm/i915: Remove excess inline keywords
diff mbox

Message ID 1431366550-25659-1-git-send-email-ville.syrjala@linux.intel.com
State New
Headers show

Commit Message

Ville Syrjala May 11, 2015, 5:49 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Remove some inline keywords. One of the functions has clearly outgrown
it anyway, so let's just leave it to the compiler.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Jani Nikula May 12, 2015, 8:52 a.m. UTC | #1
On Mon, 11 May 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Remove some inline keywords. One of the functions has clearly outgrown
> it anyway, so let's just leave it to the compiler.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_irq.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 9da955e..9c5371b 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1386,7 +1386,7 @@ static int i915_port_to_hotplug_shift(enum port port)
>  	}
>  }
>  
> -static inline enum port get_port_from_pin(enum hpd_pin pin)
> +static enum port get_port_from_pin(enum hpd_pin pin)
>  {
>  	switch (pin) {
>  	case HPD_PORT_B:
> @@ -1400,10 +1400,10 @@ static inline enum port get_port_from_pin(enum hpd_pin pin)
>  	}
>  }
>  
> -static inline void intel_hpd_irq_handler(struct drm_device *dev,
> -					 u32 hotplug_trigger,
> -					 u32 dig_hotplug_reg,
> -					 const u32 hpd[HPD_NUM_PINS])
> +static void intel_hpd_irq_handler(struct drm_device *dev,
> +				  u32 hotplug_trigger,
> +				  u32 dig_hotplug_reg,
> +				  const u32 hpd[HPD_NUM_PINS])
>  {
>  	struct drm_i915_private *dev_priv = dev->dev_private;
>  	int i;
> -- 
> 2.0.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patch
diff mbox

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 9da955e..9c5371b 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1386,7 +1386,7 @@  static int i915_port_to_hotplug_shift(enum port port)
 	}
 }
 
-static inline enum port get_port_from_pin(enum hpd_pin pin)
+static enum port get_port_from_pin(enum hpd_pin pin)
 {
 	switch (pin) {
 	case HPD_PORT_B:
@@ -1400,10 +1400,10 @@  static inline enum port get_port_from_pin(enum hpd_pin pin)
 	}
 }
 
-static inline void intel_hpd_irq_handler(struct drm_device *dev,
-					 u32 hotplug_trigger,
-					 u32 dig_hotplug_reg,
-					 const u32 hpd[HPD_NUM_PINS])
+static void intel_hpd_irq_handler(struct drm_device *dev,
+				  u32 hotplug_trigger,
+				  u32 dig_hotplug_reg,
+				  const u32 hpd[HPD_NUM_PINS])
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	int i;