[2/2] ARM: dts: rockchip: add system-power-controller to act8846
diff mbox

Message ID 64DE272A-FD25-406C-A51B-6C5B76DA5171@stud.hs-offenburg.de
State New
Headers show

Commit Message

Michael Niewöhner May 11, 2015, 8:57 p.m. UTC
Add system-power-controller to act8846 in rk3188-radxarock.dts in addition to
the act8846 patch fixing the reboot kernel panic

Signed-off-by: Michael Niewoehner <mniewoeh@stud.hs-offenburg.de>
---
 arch/arm/boot/dts/rk3188-radxarock.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Heiko Stübner May 11, 2015, 9:57 p.m. UTC | #1
Am Montag, 11. Mai 2015, 22:57:21 schrieb Michael Niewöhner:
> Add system-power-controller to act8846 in rk3188-radxarock.dts in addition
> to the act8846 patch fixing the reboot kernel panic
> 
> Signed-off-by: Michael Niewoehner <mniewoeh@stud.hs-offenburg.de>

I have to ask, are you ok with the pending dts relicensing to a gpl2/x11 dual 
license [0]?

Otherwise this looks fine and the act8846 is the power-controller of the 
radxarock in any case, so I'll take this one in any case.


Heiko

[0] http://lists.infradead.org/pipermail/linux-rockchip/2015-March/002644.html


> ---
>  arch/arm/boot/dts/rk3188-radxarock.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts
> b/arch/arm/boot/dts/rk3188-radxarock.dts index bdf8570..225a0eb 100644
> --- a/arch/arm/boot/dts/rk3188-radxarock.dts
> +++ b/arch/arm/boot/dts/rk3188-radxarock.dts
> @@ -152,6 +152,7 @@
>  		compatible = "active-semi,act8846";
>  		reg = <0x5a>;
>  		status = "okay";
> +		system-power-controller;
> 
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&act8846_dvs0_ctl>;
Michael Niewöhner May 12, 2015, 7:22 a.m. UTC | #2
I agree on relicensing to gpl2/x11.

Michael





> Am 11.05.2015 um 23:58 schrieb Heiko Stuebner <heiko@sntech.de>:
> 
> Am Montag, 11. Mai 2015, 22:57:21 schrieb Michael Niewöhner:
>> Add system-power-controller to act8846 in rk3188-radxarock.dts in
addition
>> to the act8846 patch fixing the reboot kernel panic
>> 
>> Signed-off-by: Michael Niewoehner <mniewoeh@stud.hs-offenburg.de>
> 
> I have to ask, are you ok with the pending dts relicensing to a
gpl2/x11 dual 
> license [0]?
> 
> Otherwise this looks fine and the act8846 is the power-controller of
the 
> radxarock in any case, so I'll take this one in any case.
> 
> 
> Heiko
> 
> [0]
http://lists.infradead.org/pipermail/linux-rockchip/2015-March/002644.html
> 
> 
>> ---
>> arch/arm/boot/dts/rk3188-radxarock.dts | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts
>> b/arch/arm/boot/dts/rk3188-radxarock.dts index bdf8570..225a0eb
100644
>> --- a/arch/arm/boot/dts/rk3188-radxarock.dts
>> +++ b/arch/arm/boot/dts/rk3188-radxarock.dts
>> @@ -152,6 +152,7 @@
>>        compatible = "active-semi,act8846";
>>        reg = <0x5a>;
>>        status = "okay";
>> +        system-power-controller;
>> 
>>        pinctrl-names = "default";
>>        pinctrl-0 = <&act8846_dvs0_ctl>;
>
Heiko Stübner May 12, 2015, 8:44 p.m. UTC | #3
Am Montag, 11. Mai 2015, 22:57:21 schrieb Michael Niewöhner:
> Add system-power-controller to act8846 in rk3188-radxarock.dts in addition
> to the act8846 patch fixing the reboot kernel panic
> 
> Signed-off-by: Michael Niewoehner <mniewoeh@stud.hs-offenburg.de>

As the act8846 is the system-power-controller in any case (for example to
powerdown the board) I've applied this patch to my dts branch for 4.2 [0],
after adapting the commit message slightly to make it a bit more generic:
----
ARM: dts: rockchip: add system-power-controller to act8846 on radxarock
The act8846 is the main pmic and system-power-controller on radxarock boards,
so add the necessary property.
----

Hope that is ok with you :-)

Heiko


[0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.2-armsoc/dts&id=9ab79be0da98e371f1d2f9c01ac25745639718d1

Patch
diff mbox

diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts
index bdf8570..225a0eb 100644
--- a/arch/arm/boot/dts/rk3188-radxarock.dts
+++ b/arch/arm/boot/dts/rk3188-radxarock.dts
@@ -152,6 +152,7 @@ 
 		compatible = "active-semi,act8846";
 		reg = <0x5a>;
 		status = "okay";
+		system-power-controller;
 
 		pinctrl-names = "default";
 		pinctrl-0 = <&act8846_dvs0_ctl>;