[2/2] drm/i915: Output scaler related pipe config debug in a single line
diff mbox

Message ID 1431532268-4363-2-git-send-email-tvrtko.ursulin@linux.intel.com
State New
Headers show

Commit Message

Tvrtko Ursulin May 13, 2015, 3:51 p.m. UTC
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Just so it is grouped logically in line with other data and makes a
rather verbose output a bit shorter.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chandra Konduru <chandra.konduru@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Lespiau, Damien May 13, 2015, 4:26 p.m. UTC | #1
On Wed, May 13, 2015 at 04:51:08PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Just so it is grouped logically in line with other data and makes a
> rather verbose output a bit shorter.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Chandra Konduru <chandra.konduru@intel.com>

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Shuang He May 15, 2015, 1:48 p.m. UTC | #2
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6409
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                                  234/234              234/234
ILK                                  262/262              262/262
SNB                 -1              282/282              281/282
IVB                                  300/300              300/300
BYT                                  254/254              254/254
BDW                                  275/275              275/275
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
 SNB  igt@pm_rpm@dpms-mode-unset-non-lpsp      DMESG_WARN(4)PASS(1)      DMESG_WARN(1)
(dmesg patch applied)WARNING:at_drivers/gpu/drm/i915/intel_uncore.c:#assert_device_not_suspended[i915]()@WARNING:.* at .* assert_device_not_suspended+0x
Note: You need to pay more attention to line start with '*'
Chandra Konduru May 18, 2015, 5:27 a.m. UTC | #3
Reviewed-by: Chandra Konduru <chandra.konduru@intel.com>

> -----Original Message-----
> From: Tvrtko Ursulin [mailto:tvrtko.ursulin@linux.intel.com]
> Sent: Wednesday, May 13, 2015 8:51 AM
> To: Intel-gfx@lists.freedesktop.org
> Cc: Ursulin, Tvrtko; Konduru, Chandra
> Subject: [PATCH 2/2] drm/i915: Output scaler related pipe config debug in a
> single line
> 
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Just so it is grouped logically in line with other data and makes a rather verbose
> output a bit shorter.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Chandra Konduru <chandra.konduru@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index b3ed8a0..92f3324 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11404,9 +11404,10 @@ static void intel_dump_pipe_config(struct
> intel_crtc *crtc,
>  	DRM_DEBUG_KMS("port clock: %d\n", pipe_config->port_clock);
>  	DRM_DEBUG_KMS("pipe src size: %dx%d\n",
>  		      pipe_config->pipe_src_w, pipe_config->pipe_src_h);
> -	DRM_DEBUG_KMS("num_scalers: %d\n", crtc->num_scalers);
> -	DRM_DEBUG_KMS("scaler_users: 0x%x\n", pipe_config-
> >scaler_state.scaler_users);
> -	DRM_DEBUG_KMS("scaler id: %d\n", pipe_config-
> >scaler_state.scaler_id);
> +	DRM_DEBUG_KMS("num_scalers: %d, scaler_users: 0x%x, scaler_id:
> %d\n",
> +		      crtc->num_scalers,
> +		      pipe_config->scaler_state.scaler_users,
> +		      pipe_config->scaler_state.scaler_id);
>  	DRM_DEBUG_KMS("gmch pfit: control: 0x%08x, ratios: 0x%08x, lvds
> border: 0x%08x\n",
>  		      pipe_config->gmch_pfit.control,
>  		      pipe_config->gmch_pfit.pgm_ratios,
> --
> 2.4.0
Daniel Vetter May 18, 2015, 7:58 a.m. UTC | #4
On Mon, May 18, 2015 at 05:27:51AM +0000, Konduru, Chandra wrote:
> Reviewed-by: Chandra Konduru <chandra.konduru@intel.com>
> 
> > -----Original Message-----
> > From: Tvrtko Ursulin [mailto:tvrtko.ursulin@linux.intel.com]
> > Sent: Wednesday, May 13, 2015 8:51 AM
> > To: Intel-gfx@lists.freedesktop.org
> > Cc: Ursulin, Tvrtko; Konduru, Chandra
> > Subject: [PATCH 2/2] drm/i915: Output scaler related pipe config debug in a
> > single line
> > 
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > 
> > Just so it is grouped logically in line with other data and makes a rather verbose
> > output a bit shorter.
> > 
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Chandra Konduru <chandra.konduru@intel.com>

Queued for -next, thanks for the patch.
-Daniel

> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index b3ed8a0..92f3324 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -11404,9 +11404,10 @@ static void intel_dump_pipe_config(struct
> > intel_crtc *crtc,
> >  	DRM_DEBUG_KMS("port clock: %d\n", pipe_config->port_clock);
> >  	DRM_DEBUG_KMS("pipe src size: %dx%d\n",
> >  		      pipe_config->pipe_src_w, pipe_config->pipe_src_h);
> > -	DRM_DEBUG_KMS("num_scalers: %d\n", crtc->num_scalers);
> > -	DRM_DEBUG_KMS("scaler_users: 0x%x\n", pipe_config-
> > >scaler_state.scaler_users);
> > -	DRM_DEBUG_KMS("scaler id: %d\n", pipe_config-
> > >scaler_state.scaler_id);
> > +	DRM_DEBUG_KMS("num_scalers: %d, scaler_users: 0x%x, scaler_id:
> > %d\n",
> > +		      crtc->num_scalers,
> > +		      pipe_config->scaler_state.scaler_users,
> > +		      pipe_config->scaler_state.scaler_id);
> >  	DRM_DEBUG_KMS("gmch pfit: control: 0x%08x, ratios: 0x%08x, lvds
> > border: 0x%08x\n",
> >  		      pipe_config->gmch_pfit.control,
> >  		      pipe_config->gmch_pfit.pgm_ratios,
> > --
> > 2.4.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patch
diff mbox

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index b3ed8a0..92f3324 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11404,9 +11404,10 @@  static void intel_dump_pipe_config(struct intel_crtc *crtc,
 	DRM_DEBUG_KMS("port clock: %d\n", pipe_config->port_clock);
 	DRM_DEBUG_KMS("pipe src size: %dx%d\n",
 		      pipe_config->pipe_src_w, pipe_config->pipe_src_h);
-	DRM_DEBUG_KMS("num_scalers: %d\n", crtc->num_scalers);
-	DRM_DEBUG_KMS("scaler_users: 0x%x\n", pipe_config->scaler_state.scaler_users);
-	DRM_DEBUG_KMS("scaler id: %d\n", pipe_config->scaler_state.scaler_id);
+	DRM_DEBUG_KMS("num_scalers: %d, scaler_users: 0x%x, scaler_id: %d\n",
+		      crtc->num_scalers,
+		      pipe_config->scaler_state.scaler_users,
+		      pipe_config->scaler_state.scaler_id);
 	DRM_DEBUG_KMS("gmch pfit: control: 0x%08x, ratios: 0x%08x, lvds border: 0x%08x\n",
 		      pipe_config->gmch_pfit.control,
 		      pipe_config->gmch_pfit.pgm_ratios,