From patchwork Fri May 15 21:10:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 6416331 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6F4F99F1CC for ; Fri, 15 May 2015 21:10:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 923BE20528 for ; Fri, 15 May 2015 21:10:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE71520444 for ; Fri, 15 May 2015 21:10:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945998AbbEOVKk (ORCPT ); Fri, 15 May 2015 17:10:40 -0400 Received: from mailrelay101.isp.belgacom.be ([195.238.20.128]:13977 "EHLO mailrelay101.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945947AbbEOVKj (ORCPT ); Fri, 15 May 2015 17:10:39 -0400 X-Belgacom-Dynamic: yes X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=aVuRYB9jFzFsbHnyIO6WTXMsFsysg296qeRS+2aVNsk= c=1 sm=2 a=Z4Rwk6OoAAAA:8 a=Rk0ikYUbO7HlXf0dXVkA:9 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DgDwB3YFZV/yMoQ1dcgxCBMrJbBwEBAQEFAYEEmE2BNk0BAQEBAQGBC0EDhAwvI4EaN4gwAdd7hhaKKR2EFwWSO4sZln8jYWYBgjI8MYJGAQEB Received: from 35.40-67-87.adsl-dyn.isp.belgacom.be (HELO localhost.home.) ([87.67.40.35]) by relay.skynet.be with ESMTP; 15 May 2015 23:10:18 +0200 From: Fabian Frederick To: linux-kernel@vger.kernel.org Cc: Fabian Frederick , Andrew Morton , linux-fsdevel@vger.kernel.org Subject: [PATCH 1/1 linux-next] fs/affs/symlink.c: remove unneeded err variable Date: Fri, 15 May 2015 23:10:15 +0200 Message-Id: <1431724215-27514-1-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 2.4.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP err is only assigned to -EIO Return that value at the end of fail context. Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/symlink.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/affs/symlink.c b/fs/affs/symlink.c index f39b71c..ea5b69a 100644 --- a/fs/affs/symlink.c +++ b/fs/affs/symlink.c @@ -16,14 +16,12 @@ static int affs_symlink_readpage(struct file *file, struct page *page) struct inode *inode = page->mapping->host; char *link = kmap(page); struct slink_front *lf; - int err; int i, j; char c; char lc; pr_debug("follow_link(ino=%lu)\n", inode->i_ino); - err = -EIO; bh = affs_bread(inode->i_sb, inode->i_ino); if (!bh) goto fail; @@ -66,7 +64,7 @@ fail: SetPageError(page); kunmap(page); unlock_page(page); - return err; + return -EIO; } const struct address_space_operations affs_symlink_aops = {