xfs/007: use gquotino for project quotas on pre-v5 superblocks
diff mbox

Message ID 1431963509-54017-1-git-send-email-bfoster@redhat.com
State New
Headers show

Commit Message

Brian Foster May 18, 2015, 3:38 p.m. UTC
This test checks block usage on quota inodes based on the inode number
values stored in the superblock. Version 5 superblocks (crc=1) have an
independent project quota inode field to support concurrent group and
project quotas. Older superblocks do not have the pquotino field. The
gquotino field is reused for project quotas.

The test currently unconditionally uses the pquotino field to determine
the project quota inode. This causes failures on pre-v5 superblocks as
the test queries the block usage of an incorrect inode number. Update
the test to use gquotino as the project quota inode on such filesystems.

Signed-off-by: Brian Foster <bfoster@redhat.com>
 tests/xfs/007 | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff mbox

diff --git a/tests/xfs/007 b/tests/xfs/007
index 01cc421..76c100f 100755
--- a/tests/xfs/007
+++ b/tests/xfs/007
@@ -50,7 +50,8 @@  _require_xfs_quota
 rm -f $seqres.full
-_scratch_mkfs_xfs >/dev/null 2>&1
+_scratch_mkfs_xfs | _filter_mkfs > /dev/null 2> $tmp.mkfs
+. $tmp.mkfs
@@ -88,11 +89,16 @@  _qmount_option "uquota,gquota"
 do_test uquotino gquotino ug
-# Test user and project
+# Test user and project. Note that pquotino only exists on v5 (crc=1)
+# superblocks. Older supers reuse gquotino.
+if [ $_fs_has_crcs == 0 ]; then
+	PQUOTINO=gquotino
 _qmount_option "uquota,pquota"
 _require_prjquota $SCRATCH_DEV
-do_test uquotino pquotino up
+do_test uquotino $PQUOTINO up
 # success, all done