[2/2] ARM: dts: sabrelite: use simple-panel instead of display-timings for LVDS0
diff mbox

Message ID 1432050616-11465-3-git-send-email-eric.nelson@boundarydevices.com
State New, archived
Headers show

Commit Message

Eric Nelson May 19, 2015, 3:50 p.m. UTC
Also add label for backlight_lvds and connect it to the LVDS display.

Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
V2 changes 'alias' in commit message to 'label'

 arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)

Comments

Philipp Zabel May 19, 2015, 4:04 p.m. UTC | #1
Hi Eric,

Am Dienstag, den 19.05.2015, 08:50 -0700 schrieb Eric Nelson:
> Also add label for backlight_lvds and connect it to the LVDS display.
> 
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
[...]
> @@ -129,6 +129,17 @@
>  		power-supply = <&reg_3p3v>;
>  		status = "okay";
>  	};
> +
> +	panel {
> +		compatible = "hannstar,hsd100pxn1";
> +		backlight = <&backlight_lvds>;
> +
> +		port {
> +			panel_in: endpoint {
> +				remote-endpoint = <&lvds0_out>;
> +			};
> +		};
> +	};
>  };
>  
>  &audmux {
> @@ -374,18 +385,11 @@
>  		fsl,data-width = <18>;

The fsl,data-width property shouldn't be needed anymore if you
set .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG for the hsd100pxn1
panel in panel-simple.c.

regards
Philipp
Eric Nelson May 19, 2015, 4:51 p.m. UTC | #2
On 05/19/2015 09:04 AM, Philipp Zabel wrote:
> Hi Eric,
> 
> Am Dienstag, den 19.05.2015, 08:50 -0700 schrieb Eric Nelson:
>> Also add label for backlight_lvds and connect it to the LVDS display.
>>
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>> ---
> [...]
>> @@ -129,6 +129,17 @@
>>  		power-supply = <&reg_3p3v>;
>>  		status = "okay";
>>  	};
>> +
>> +	panel {
>> +		compatible = "hannstar,hsd100pxn1";
>> +		backlight = <&backlight_lvds>;
>> +
>> +		port {
>> +			panel_in: endpoint {
>> +				remote-endpoint = <&lvds0_out>;
>> +			};
>> +		};
>> +	};
>>  };
>>  
>>  &audmux {
>> @@ -374,18 +385,11 @@
>>  		fsl,data-width = <18>;
> 
> The fsl,data-width property shouldn't be needed anymore if you
> set .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG for the hsd100pxn1
> panel in panel-simple.c.
> 

Thanks again Philipp.

That's a much better place to put it, since this is a panel feature,
not a feature of the LVDS channel.
Eric Nelson May 19, 2015, 6:52 p.m. UTC | #3
Hi Philipp,

On 05/19/2015 09:51 AM, Eric Nelson wrote:
> On 05/19/2015 09:04 AM, Philipp Zabel wrote:
>> Hi Eric,
>>
>> Am Dienstag, den 19.05.2015, 08:50 -0700 schrieb Eric Nelson:
>>> Also add label for backlight_lvds and connect it to the LVDS display.
>>>
>>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>>> ---
>> [...]
>>>  
>>>  &audmux {
>>> @@ -374,18 +385,11 @@
>>>  		fsl,data-width = <18>;
>>
>> The fsl,data-width property shouldn't be needed anymore if you
>> set .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG for the hsd100pxn1
>> panel in panel-simple.c.
>>

Are you planning to submit a patch to panel-simple.c for this?

Because of the dependency, I'd like to handle this in a separate
patch instead of V3 of this patch set.

Please advise,


Eric
Philipp Zabel May 20, 2015, 9:35 a.m. UTC | #4
Hi Eric,

Am Dienstag, den 19.05.2015, 11:52 -0700 schrieb Eric Nelson:
> Hi Philipp,
> 
> On 05/19/2015 09:51 AM, Eric Nelson wrote:
> > On 05/19/2015 09:04 AM, Philipp Zabel wrote:
> >> Hi Eric,
> >>
> >> Am Dienstag, den 19.05.2015, 08:50 -0700 schrieb Eric Nelson:
> >>> Also add label for backlight_lvds and connect it to the LVDS display.
> >>>
> >>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> >>> ---
> >> [...]
> >>>  
> >>>  &audmux {
> >>> @@ -374,18 +385,11 @@
> >>>  		fsl,data-width = <18>;
> >>
> >> The fsl,data-width property shouldn't be needed anymore if you
> >> set .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG for the hsd100pxn1
> >> panel in panel-simple.c.
> >>
> 
> Are you planning to submit a patch to panel-simple.c for this?

Done.

> Because of the dependency, I'd like to handle this in a separate
> patch instead of V3 of this patch set.

I agree, it's better to remove this in a separate step after the panel
driver is merged.

regards
Philipp

Patch
diff mbox

diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
index 483856e2..6ed80b8 100644
--- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
@@ -121,7 +121,7 @@ 
 		status = "okay";
 	};
 
-	backlight_lvds {
+	backlight_lvds: backlight_lvds {
 		compatible = "pwm-backlight";
 		pwms = <&pwm4 0 5000000>;
 		brightness-levels = <0 4 8 16 32 64 128 255>;
@@ -129,6 +129,17 @@ 
 		power-supply = <&reg_3p3v>;
 		status = "okay";
 	};
+
+	panel {
+		compatible = "hannstar,hsd100pxn1";
+		backlight = <&backlight_lvds>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&lvds0_out>;
+			};
+		};
+	};
 };
 
 &audmux {
@@ -374,18 +385,11 @@ 
 		fsl,data-width = <18>;
 		status = "okay";
 
-		display-timings {
-			native-mode = <&timing0>;
-			timing0: hsd100pxn1 {
-				clock-frequency = <65000000>;
-				hactive = <1024>;
-				vactive = <768>;
-				hback-porch = <220>;
-				hfront-porch = <40>;
-				vback-porch = <21>;
-				vfront-porch = <7>;
-				hsync-len = <60>;
-				vsync-len = <10>;
+		port@4 {
+			reg = <4>;
+
+			lvds0_out: endpoint {
+				remote-endpoint = <&panel_in>;
 			};
 		};
 	};