From patchwork Wed May 20 14:09:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 6446621 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D872B9F318 for ; Wed, 20 May 2015 14:10:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 91E2E2039E for ; Wed, 20 May 2015 14:10:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9421620035 for ; Wed, 20 May 2015 14:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753119AbbETOKJ (ORCPT ); Wed, 20 May 2015 10:10:09 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:41136 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753195AbbETOKI (ORCPT ); Wed, 20 May 2015 10:10:08 -0400 Received: from pps.filterd (m0004060 [127.0.0.1]) by mx0b-00082601.pphosted.com (8.14.5/8.14.5) with SMTP id t4KE6Zfp024949; Wed, 20 May 2015 07:10:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=from : to : subject : date : message-id : mime-version : content-type; s=facebook; bh=xhIqtJLzBRqOx4hY40aV7uJ+D2uqiv468LaHftCUk1E=; b=UwvPRKSVFwJ0hnvm3SRMyzJ4Phghuo76+EE/u4KxYW92fdZu0P6JLiBxIfgk6koTqEYg FR54RU5d2fF5VmODHmrXtwnq9MADdD30CmYpPk4Bwxo49jdGv3z7fgXHg1eJHnqIbltk /S8i8Z+n2SorU/6TzQhUGnUBobbXdfY2ZMg= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0b-00082601.pphosted.com with ESMTP id 1ugtvj05cw-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 20 May 2015 07:10:04 -0700 Received: from localhost (192.168.54.13) by mail.thefacebook.com (192.168.16.22) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 20 May 2015 07:10:01 -0700 From: Josef Bacik To: , Subject: [PATCH V2] fstests: add a test for fallocate+truncate Date: Wed, 20 May 2015 10:09:59 -0400 Message-ID: <1432130999-3956-1-git-send-email-jbacik@fb.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33, 0.0.0000 definitions=2015-05-20_04:2015-05-19, 2015-05-20, 1970-01-01 signatures=0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There was some confused about what the fs was supposed to do when you truncate at i_size with preallocated space past i_size. We decided on the following things 1) truncate(i_size) will trim all blocks past i_size. 2) truncate(x) where x > i_size will not trim all blocks past i_size. This test is to make sure we're all acting sanely. Thanks, Signed-off-by: Josef Bacik Reviewed-by: Eryu Guan --- V1->V2: -changed the test number -fixed up minor comments from Eryu. tests/generic/087 | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/087.out | 6 +++++ tests/generic/group | 1 + 3 files changed, 78 insertions(+) create mode 100644 tests/generic/087 create mode 100644 tests/generic/087.out diff --git a/tests/generic/087 b/tests/generic/087 new file mode 100644 index 0000000..f57e89d --- /dev/null +++ b/tests/generic/087 @@ -0,0 +1,71 @@ +#! /bin/bash +# FS QA Test No. 087 +# +# fallocate/truncate tests with FALLOC_FL_KEEP_SIZE option. +# Verify if the disk space is released after truncating a file to i_size after +# writing to a portion of a preallocated range. +# +# This also verifies that truncat'ing up past i_size doesn't remove the +# preallocated space. +# +#----------------------------------------------------------------------- +# Copyright (c) 2015 Facebook. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=0 # success is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/punch + +# real QA test starts here + +# Modify as appropriate. +_supported_fs generic +_supported_os Linux +_require_test +_require_xfs_io_command "falloc" +_require_fiemap + +# First test to make sure that truncating at i_size trims the preallocated bit +# past i_size +$XFS_IO_PROG -f -c "falloc -k 0 10M" -c "pwrite 0 5M" -c "truncate 5M"\ + $TEST_DIR/testfile.$seq | _filter_xfs_io +sync +$XFS_IO_PROG -c "fiemap -v" $TEST_DIR/testfile.$seq | _filter_fiemap + +# Now verify that if we truncate up past i_size we don't trim the preallocated +# bit +$XFS_IO_PROG -c "falloc -k 5M 5M" -c "truncate 7M" $TEST_DIR/testfile.$seq +$XFS_IO_PROG -c "fiemap -v" $TEST_DIR/testfile.$seq | _filter_fiemap + +# success, all done +exit diff --git a/tests/generic/087.out b/tests/generic/087.out new file mode 100644 index 0000000..c7cef59 --- /dev/null +++ b/tests/generic/087.out @@ -0,0 +1,6 @@ +QA output created by 087 +wrote 5242880/5242880 bytes at offset 0 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +0: [0..10239]: data +0: [0..10239]: data +1: [10240..20479]: unwritten diff --git a/tests/generic/group b/tests/generic/group index 927a91a..a801af4 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -90,6 +90,7 @@ 085 auto freeze mount 086 auto prealloc preallocrw quick 088 perms auto quick +087 auto quick prealloc 089 metadata auto 091 rw auto quick 093 attr cap udf auto