diff mbox

xfstests: correct comment in generic/135

Message ID 1432168977-4330-1-git-send-email-shhuiw@foxmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shenghui Wang May 21, 2015, 12:42 a.m. UTC 
xfs_io '-d' specifies direct IO, not sync IO.

Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
---
 tests/generic/135 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Sandeen May 21, 2015, 1:06 a.m. UTC | #1 
On 5/20/15 7:42 PM, Wang Sheng-Hui wrote:
> xfs_io '-d' specifies direct IO, not sync IO.
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>

Ok, sure.  :)

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  tests/generic/135 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/135 b/tests/generic/135
> index 79558f5..2444803 100755
> --- a/tests/generic/135
> +++ b/tests/generic/135
> @@ -63,7 +63,7 @@ $XFS_IO_PROG -f -c 'pwrite -b 4k -S 0x12 0 4k' async_file > /dev/null
>  # create file with sync I/O
>  $XFS_IO_PROG -f -s -c 'pwrite -b 4k -S 0x34 0 4k' sync_file > /dev/null
>  
> -# create file with sync I/O
> +# create file with direct I/O
>  $XFS_IO_PROG -f -d -c 'pwrite -b 4k -S 0x56 0 4k' direct_file > /dev/null
>  
>  # create file, truncate and then dirty again
> 

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tests/generic/135 b/tests/generic/135
index 79558f5..2444803 100755
--- a/tests/generic/135
+++ b/tests/generic/135
@@ -63,7 +63,7 @@  $XFS_IO_PROG -f -c 'pwrite -b 4k -S 0x12 0 4k' async_file > /dev/null
 # create file with sync I/O
 $XFS_IO_PROG -f -s -c 'pwrite -b 4k -S 0x34 0 4k' sync_file > /dev/null
 
-# create file with sync I/O
+# create file with direct I/O
 $XFS_IO_PROG -f -d -c 'pwrite -b 4k -S 0x56 0 4k' direct_file > /dev/null
 
 # create file, truncate and then dirty again