diff mbox

[v4,3/3] ASoC: qcom: fix STORM board Kconfig

Message ID 1432310057-5358-1-git-send-email-srinivas.kandagatla@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Srinivas Kandagatla May 22, 2015, 3:54 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

This patch is a fixup to correct dependencies in patch 9bae4880acee
("ASoC: qcom: move ipq806x specific bits out of lpass driver.")

Originally this change-set was suggested by Arnd on mailing list.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnd Bergmann May 22, 2015, 4:33 p.m. UTC | #1 
On Friday 22 May 2015 16:54:17 Srinivas Kandagatla wrote:
> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> index 6ecac6c..f50197e 100644
> --- a/sound/soc/qcom/Kconfig
> +++ b/sound/soc/qcom/Kconfig
> @@ -26,7 +26,7 @@ config SND_SOC_LPASS_APQ8016
>  
>  config SND_SOC_STORM
>         tristate "ASoC I2S support for Storm boards"
> -       depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST
> +       depends on SND_SOC_QCOM && (ARCH_QCOM || COMPILE_TEST)
>         select SND_SOC_LPASS_IPQ806X
>         select SND_SOC_MAX98357A
>         help
> -- 

Do you still have the problem that you are selecting another symbol
that 'depends on OF', but this one does not have that dependency,
or did you drop that patch now before it could get picked up?

	Arnd
Srinivas Kandagatla May 26, 2015, 6:58 a.m. UTC | #2 
On 22/05/15 17:33, Arnd Bergmann wrote:
> On Friday 22 May 2015 16:54:17 Srinivas Kandagatla wrote:
>> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
>> index 6ecac6c..f50197e 100644
>> --- a/sound/soc/qcom/Kconfig
>> +++ b/sound/soc/qcom/Kconfig
>> @@ -26,7 +26,7 @@ config SND_SOC_LPASS_APQ8016
>>
>>   config SND_SOC_STORM
>>          tristate "ASoC I2S support for Storm boards"
>> -       depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST
>> +       depends on SND_SOC_QCOM && (ARCH_QCOM || COMPILE_TEST)
>>          select SND_SOC_LPASS_IPQ806X
>>          select SND_SOC_MAX98357A
>>          help
>> --
>
> Do you still have the problem that you are selecting another symbol
> that 'depends on OF', but this one does not have that dependency,
> or did you drop that patch now before it could get picked up?

Yes, I dropped the OF dependency patch, as these drivers could be 
compile tested.

--srini

>
> 	Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
Mark Brown June 2, 2015, 7:56 p.m. UTC | #3 
On Fri, May 22, 2015 at 04:54:17PM +0100, Srinivas Kandagatla wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This patch is a fixup to correct dependencies in patch 9bae4880acee
> ("ASoC: qcom: move ipq806x specific bits out of lpass driver.")
> 
> Originally this change-set was suggested by Arnd on mailing list.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Did you write this or did Arnd?  The authorship suggests that he wrote
it but your signoff appears before his.  I've assumed Arnd wrote it and
reordered but please be more careful and let me know if my assumption is
wrong...
diff mbox

Patch

diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index 6ecac6c..f50197e 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -26,7 +26,7 @@  config SND_SOC_LPASS_APQ8016
 
 config SND_SOC_STORM
 	tristate "ASoC I2S support for Storm boards"
-	depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST
+	depends on SND_SOC_QCOM && (ARCH_QCOM || COMPILE_TEST)
 	select SND_SOC_LPASS_IPQ806X
 	select SND_SOC_MAX98357A
 	help