PM / AVS: rockchip-io: depend on CONFIG_POWER_AVS
diff mbox

Message ID 28649509.lINlAh7Sts@phil
State New
Headers show

Commit Message

Heiko Stübner May 23, 2015, 1:41 p.m. UTC
The rockchip io-domain driver currently only depends on ARCH_ROCKCHIP
itself. This makes it possible to select the power-domain driver, but
not the POWER_AVS class and results in the iodomain-driver not getting
build in this case.

So add the additional dependency, which also results in the driver
config option now being placed nicely into the AVS submenu.

Fixes: 662a958638bd ("PM / AVS: rockchip-io: add driver handling Rockchip io domains")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
Found while trying to make the wifi on current rk3288 Chromebooks work.

 drivers/power/avs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sebastian Reichel May 24, 2015, 7:54 p.m. UTC | #1
Hi,

On Sat, May 23, 2015 at 03:41:30PM +0200, Heiko Stuebner wrote:
> The rockchip io-domain driver currently only depends on ARCH_ROCKCHIP
> itself. This makes it possible to select the power-domain driver, but
> not the POWER_AVS class and results in the iodomain-driver not getting
> build in this case.
> 
> So add the additional dependency, which also results in the driver
> config option now being placed nicely into the AVS submenu.
> 
> Fixes: 662a958638bd ("PM / AVS: rockchip-io: add driver handling Rockchip io domains")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Looks like the power supply entry in the MAINTAINERS file is missing
an "X: drivers/power/avs/" entry.

-- Sebastian
Kevin Hilman May 26, 2015, 11:21 p.m. UTC | #2
Heiko Stuebner <heiko@sntech.de> writes:

> The rockchip io-domain driver currently only depends on ARCH_ROCKCHIP
> itself. This makes it possible to select the power-domain driver, but
> not the POWER_AVS class and results in the iodomain-driver not getting
> build in this case.
>
> So add the additional dependency, which also results in the driver
> config option now being placed nicely into the AVS submenu.
>
> Fixes: 662a958638bd ("PM / AVS: rockchip-io: add driver handling Rockchip io domains")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Acked-by: Kevin Hilman <khilman@linaro.org>

Rafael, feel free to queue this up as a fix.  I don't have any other
drivers/power/avs stuff queued up.

Kevin

Patch
diff mbox

diff --git a/drivers/power/avs/Kconfig b/drivers/power/avs/Kconfig
index 7f3d389..a67eeac 100644
--- a/drivers/power/avs/Kconfig
+++ b/drivers/power/avs/Kconfig
@@ -13,7 +13,7 @@  menuconfig POWER_AVS
 
 config ROCKCHIP_IODOMAIN
         tristate "Rockchip IO domain support"
-        depends on ARCH_ROCKCHIP && OF
+        depends on POWER_AVS && ARCH_ROCKCHIP && OF
         help
           Say y here to enable support io domains on Rockchip SoCs. It is
           necessary for the io domain setting of the SoC to match the