From patchwork Tue May 26 04:18:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 6477761 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D3DD39F1C1 for ; Tue, 26 May 2015 04:21:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1BDFD204A7 for ; Tue, 26 May 2015 04:21:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53C13203F7 for ; Tue, 26 May 2015 04:21:56 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yx6L0-0000jd-IO; Tue, 26 May 2015 04:19:34 +0000 Received: from merlin.infradead.org ([2001:4978:20e::2]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yx6Ky-0000jV-3z for linux-arm-kernel@bombadil.infradead.org; Tue, 26 May 2015 04:19:32 +0000 Received: from conuserg011.nifty.com ([202.248.44.37] helo=conuserg011-v.nifty.com) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yx6Kv-0006W8-AX for linux-arm-kernel@lists.infradead.org; Tue, 26 May 2015 04:19:30 +0000 Received: from beagle.diag.org (KD111237132184.au-net.ne.jp [111.237.132.184]) (authenticated) by conuserg011-v.nifty.com with ESMTP id t4Q4IJfK006620; Tue, 26 May 2015 13:18:23 +0900 X-Nifty-SrcIP: [111.237.132.184] From: Masahiro Yamada To: linux-gpio@vger.kernel.org Subject: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure Date: Tue, 26 May 2015 13:18:29 +0900 Message-Id: <1432613909-13457-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150526_001929_770489_BB5551F8 X-CRM114-Status: UNSURE ( 9.32 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.2 (-) Cc: Linus Walleij , Michal Simek , linux-kernel@vger.kernel.org, Masahiro Yamada , =?UTF-8?q?S=C3=B6ren=20Brinkmann?= , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pinctrl_register() could fail for memory unrelated errors. Returning -EINVAL (or -ENODEV) seems more suitable for here. At least, the other pinctrl drivers do so. Signed-off-by: Masahiro Yamada --- drivers/pinctrl/pinctrl-zynq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c index 04748a4..0ff653c 100644 --- a/drivers/pinctrl/pinctrl-zynq.c +++ b/drivers/pinctrl/pinctrl-zynq.c @@ -1141,7 +1141,7 @@ static int zynq_pinctrl_probe(struct platform_device *pdev) pctrl->pctrl = pinctrl_register(&zynq_desc, &pdev->dev, pctrl); if (!pctrl->pctrl) - return -ENOMEM; + return -EINVAL; platform_set_drvdata(pdev, pctrl);