[2/2] ARM: DRA7: hwmod: Fix GPMC from preventing core suspend
diff mbox

Message ID 1433239373-14653-3-git-send-email-rogerq@ti.com
State New
Headers show

Commit Message

Roger Quadros June 2, 2015, 10:02 a.m. UTC
GPMC hwmod is flagged as HWMOD_INIT_NO_IDLE so it is kept
enabled at boot. If the GPMC driver is not loaded then
GPMC will not be idled thus preventing CORE from going idle
during suspend.

Disable HWMOD_INIT_NO_IDLE and HWMOD_INIT_NO_RESET.

The only reason HWMOD_INIT_NO_RESET was there was to retain
GPMC timings/settings configured by bootloader. We no longer
need that as we're configuring the timins in the kernel.

There is no reasoning as to why HWMOD_INIT_NO_IDLE was there.
Seems to have beein blindly copied from omap3/4 hwmod code.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Paul Walmsley June 2, 2015, 9:36 p.m. UTC | #1
On Tue, 2 Jun 2015, Roger Quadros wrote:

> GPMC hwmod is flagged as HWMOD_INIT_NO_IDLE so it is kept
> enabled at boot. If the GPMC driver is not loaded then
> GPMC will not be idled thus preventing CORE from going idle
> during suspend.
> 
> Disable HWMOD_INIT_NO_IDLE and HWMOD_INIT_NO_RESET.
> 
> The only reason HWMOD_INIT_NO_RESET was there was to retain
> GPMC timings/settings configured by bootloader. We no longer
> need that as we're configuring the timins in the kernel.
> 
> There is no reasoning as to why HWMOD_INIT_NO_IDLE was there.
> Seems to have beein blindly copied from omap3/4 hwmod code.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>

Hi Roger, could you take a look at Tony's patch "memory: omap-gpmc: Add 
Kconfig option for debug" and see if this needs to be changed in light of 
that patch?

regards,

- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Roger Quadros June 3, 2015, 10:51 a.m. UTC | #2
Paul,

On 03/06/15 00:36, Paul Walmsley wrote:
> On Tue, 2 Jun 2015, Roger Quadros wrote:
>
>> GPMC hwmod is flagged as HWMOD_INIT_NO_IDLE so it is kept
>> enabled at boot. If the GPMC driver is not loaded then
>> GPMC will not be idled thus preventing CORE from going idle
>> during suspend.
>>
>> Disable HWMOD_INIT_NO_IDLE and HWMOD_INIT_NO_RESET.
>>
>> The only reason HWMOD_INIT_NO_RESET was there was to retain
>> GPMC timings/settings configured by bootloader. We no longer
>> need that as we're configuring the timins in the kernel.
>>
>> There is no reasoning as to why HWMOD_INIT_NO_IDLE was there.
>> Seems to have beein blindly copied from omap3/4 hwmod code.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>
> Hi Roger, could you take a look at Tony's patch "memory: omap-gpmc: Add
> Kconfig option for debug" and see if this needs to be changed in light of
> that patch?

Yes. We don't need this patch if we can just rid of HWMOD_SWSUP_SIDLE
as done in the first patch.

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index 8c2fad5..52c6565 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -819,7 +819,6 @@  static struct omap_hwmod dra7xx_gpmc_hwmod = {
 	.name		= "gpmc",
 	.class		= &dra7xx_gpmc_hwmod_class,
 	.clkdm_name	= "l3main1_clkdm",
-	.flags		= HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
 	.main_clk	= "l3_iclk_div",
 	.prcm = {
 		.omap4 = {