[2/3] ARM: dts: configure regulators for Gumstix Pepper
diff mbox

Message ID 1433441299-18887-3-git-send-email-arun@gumstix.com
State New
Headers show

Commit Message

Arun Bharadwaj June 4, 2015, 6:08 p.m. UTC
From: Adam YH Lee <adam.yh.lee@gmail.com>

Boot process is halting in midway because some of the necessary voltage
regulators are deemed unused and subsequently powered off, leading to
a completely unresponsive system.

Most of the device nodes had correct voltage regulator attachments.
Yet these nodes had to set stricter enforcement on them through
'regulator-boot-on' and 'regulator-always-on' to function correctly.

Signed-off-by: Ash Charles <ashcharles@gmail.com>
---
 arch/arm/boot/dts/am335x-pepper.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Tony Lindgren June 29, 2015, 6:47 a.m. UTC | #1
* Arun Bharadwaj <arun@gumstix.com> [150604 11:10]:
> From: Adam YH Lee <adam.yh.lee@gmail.com>
> 
> Boot process is halting in midway because some of the necessary voltage
> regulators are deemed unused and subsequently powered off, leading to
> a completely unresponsive system.

OK that needs to be fixed for v4.2-rc series.
 
> Most of the device nodes had correct voltage regulator attachments.
> Yet these nodes had to set stricter enforcement on them through
> 'regulator-boot-on' and 'regulator-always-on' to function correctly.

That's a lot of regulators marked as regulator-always-on. Could
you please update the description what consumers are using them
so we know why they are all needed always-on?
 
> Signed-off-by: Ash Charles <ashcharles@gmail.com>

From Adam, sent by Arun, signed by Ash? Can you please check
that too.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ash Charles July 2, 2015, 6:34 p.m. UTC | #2
On Sun, Jun 28, 2015 at 11:47 PM, Tony Lindgren <tony@atomide.com> wrote:
>> Signed-off-by: Ash Charles <ashcharles@gmail.com>
>
> From Adam, sent by Arun, signed by Ash? Can you please check
> that too.
I reviewed Adam's original patch internally at Gumstix and my
Signed-off-by got carried along.  In future, would an 'Acked-by' from
me be more appropriate?

--Ash
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren July 3, 2015, 5:53 a.m. UTC | #3
* Ash Charles <ashcharles@gmail.com> [150702 11:37]:
> On Sun, Jun 28, 2015 at 11:47 PM, Tony Lindgren <tony@atomide.com> wrote:
> >> Signed-off-by: Ash Charles <ashcharles@gmail.com>
> >
> > From Adam, sent by Arun, signed by Ash? Can you please check
> > that too.
> I reviewed Adam's original patch internally at Gumstix and my
> Signed-off-by got carried along.  In future, would an 'Acked-by' from
> me be more appropriate?

Yes Acked-by or Reviewed-by if you did not make changes to the patch.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/boot/dts/am335x-pepper.dts b/arch/arm/boot/dts/am335x-pepper.dts
index 473d8ee..99f855d 100644
--- a/arch/arm/boot/dts/am335x-pepper.dts
+++ b/arch/arm/boot/dts/am335x-pepper.dts
@@ -415,6 +415,7 @@ 
 
 &v3v3c_reg {
 	regulator-name = "v3v3c_reg";
+	regulator-boot-on;
 	regulator-min-microvolt = <3300000>;
 	regulator-max-microvolt = <3300000>;
 	vin-supply = <&vbat>;
@@ -439,6 +440,8 @@ 
 	regulators {
 		dcdc1_reg: regulator@0 {
 			/* VDD_1V8 system supply */
+			regulator-name = "vdds_dpr";
+			regulator-always-on;
 		};
 
 		dcdc2_reg: regulator@1 {
@@ -447,6 +450,7 @@ 
 			regulator-min-microvolt = <925000>;
 			regulator-max-microvolt = <1325000>;
 			regulator-boot-on;
+			regulator-always-on;
 		};
 
 		dcdc3_reg: regulator@2 {
@@ -455,25 +459,34 @@ 
 			regulator-min-microvolt = <925000>;
 			regulator-max-microvolt = <1150000>;
 			regulator-boot-on;
+			regulator-always-on;
 		};
 
 		ldo1_reg: regulator@3 {
 			/* VRTC 1.8V always-on supply */
+			regulator-name = "vrtc,vdds";
 			regulator-always-on;
 		};
 
 		ldo2_reg: regulator@4 {
 			/* 3.3V rail */
+			regulator-name = "vdd_3v3aux";
+			regulator-always-on;
 		};
 
 		ldo3_reg: regulator@5 {
 			/* VDD_3V3A 3.3V rail */
+			regulator-name = "vdd_3v3a";
 			regulator-min-microvolt = <3300000>;
 			regulator-max-microvolt = <3300000>;
+			regulator-boot-on;
+			regulator-always-on;
 		};
 
 		ldo4_reg: regulator@6 {
 			/* VDD_3V3B 3.3V rail */
+			regulator-name = "vdd_3v3b";
+			regulator-always-on;
 		};
 	};
 };