diff mbox

[2/3] ARM: dts: fix the clock-frequency of rinato board's panel

Message ID 1434099805-16989-2-git-send-email-human.hwang@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hyungwon Hwang June 12, 2015, 9:03 a.m. UTC
Because of recent update, proper clock-frequency becomes mandatory
for validating the mode of panel. This clock-frequency must be set
appropriately for getting required frame rate.

Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
---
 arch/arm/boot/dts/exynos3250-rinato.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski June 12, 2015, 9:23 a.m. UTC | #1
2015-06-12 18:03 GMT+09:00 Hyungwon Hwang <human.hwang@samsung.com>:
> Because of recent update, proper clock-frequency becomes mandatory
> for validating the mode of panel. This clock-frequency must be set
> appropriately for getting required frame rate.
>
> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>

Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Is it a bugfix? The property is mandatory right now?

Best regards,
Krzysztof
Hyungwon Hwang June 12, 2015, 9:27 a.m. UTC | #2
On Fri, 12 Jun 2015 18:23:18 +0900
Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:

> 2015-06-12 18:03 GMT+09:00 Hyungwon Hwang <human.hwang@samsung.com>:
> > Because of recent update, proper clock-frequency becomes mandatory
> > for validating the mode of panel. This clock-frequency must be set
> > appropriately for getting required frame rate.
> >
> > Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
> 
> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Is it a bugfix? The property is mandatory right now?

With recent kernel, yes. It is mandatory for the mode to be become
available.

Best regards,
Hyungwon Hwang

> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski June 12, 2015, 9:36 a.m. UTC | #3
2015-06-12 18:27 GMT+09:00 Hyungwon Hwang <human.hwang@samsung.com>:
> On Fri, 12 Jun 2015 18:23:18 +0900
> Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>
>> 2015-06-12 18:03 GMT+09:00 Hyungwon Hwang <human.hwang@samsung.com>:
>> > Because of recent update, proper clock-frequency becomes mandatory
>> > for validating the mode of panel. This clock-frequency must be set
>> > appropriately for getting required frame rate.
>> >
>> > Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
>>
>> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> Is it a bugfix? The property is mandatory right now?
>
> With recent kernel, yes. It is mandatory for the mode to be become
> available.

So it looks like bugfix. Can you resend the patch with:
1. cc-stable and fixes tags,
2. observable bug/issue/error (error from dmesg would be enough)?

It looks quite similar to 242ddf0429

Best regards,
Krzysztof
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index 0b99068..75aba40 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -181,7 +181,7 @@ 
 
 		display-timings {
 			timing-0 {
-				clock-frequency = <0>;
+				clock-frequency = <4600000>;
 				hactive = <320>;
 				vactive = <320>;
 				hfront-porch = <1>;