From patchwork Fri Jun 19 15:24:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 6645701 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 50CF5C0020 for ; Fri, 19 Jun 2015 15:21:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5548020957 for ; Fri, 19 Jun 2015 15:21:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 6AA6B20956 for ; Fri, 19 Jun 2015 15:21:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D6CB56E686; Fri, 19 Jun 2015 08:21:46 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C2776E686 for ; Fri, 19 Jun 2015 08:21:45 -0700 (PDT) Received: by wicnd19 with SMTP id nd19so22300687wic.1 for ; Fri, 19 Jun 2015 08:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lD+eqNE5zn3l4qEN4XtV+ljhmxJwQ6CR8AQWYN2zcxE=; b=alhgqGMw2OJLm/Ovg49t5/lD5lNo/N4siKiz/socpEzEb89X52CC9su+bV5yuq3FSd qZDMVh25I3Bq/W8hqrMuyAuggVai++b4Rb60CJ+8xRQTmLkLPxVeKbmJtM6OpS1FJudM 1E+YhcTi7eK3kOJRgtQSb18xqvcG5SBoqkvNY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=lD+eqNE5zn3l4qEN4XtV+ljhmxJwQ6CR8AQWYN2zcxE=; b=kalMD9UgVlje/2t3EYpspMFrgSf15tY2OcJVjmph9LGarHsTF+XlU89QPv/9H9ZXjN RdIylJhRUjYu0nIO6oD+Ui+gwCpV+uJqWGAgfiXu4XELitMoYqTPtMug/LWVlyVD6Wwl ztlCkydO/D3nNbJ7x5SskXGVGxlmVa1dpq+Nu1+hEquVd+OUScYfNnHA0DQdK+VSDloq E9HGiomQ9ljBIuohqdfo8ZoV38P07P8bhwngQRnBNtoCLKcDmlxbiV5yhBXxw7e4oXO7 6gUSd7473nrQQE8yTgpgMspt0d7cWTAo1vwdbdKCURG2TWTa3Jf6ce5quJcNhZBx6C3W BLPA== X-Gm-Message-State: ALoCoQmzw+BMJsJVBhKOPQVC9FgKVubzR7mJ5TZAB+9rQakl2ZhnhBq/rT2CZucQQUXfRzh9A0jU X-Received: by 10.180.95.10 with SMTP id dg10mr7746815wib.41.1434727304752; Fri, 19 Jun 2015 08:21:44 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:56b5:0:22cf:30ff:fe4c:37d6]) by mx.google.com with ESMTPSA id ul1sm17496388wjc.30.2015.06.19.08.21.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jun 2015 08:21:43 -0700 (PDT) Date: Fri, 19 Jun 2015 17:24:26 +0200 From: Daniel Vetter To: Dave Airlie Message-ID: <20150619152426.GA25769@phenom.ffwll.local> References: <87r3p9imbb.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Jani Nikula , Daniel Vetter , "intel-gfx@lists.freedesktop.org" , dri-devel Subject: Re: [Intel-gfx] [PULL] drm-intel-next-fixes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Jun 19, 2015 at 01:48:13PM +1000, Dave Airlie wrote: > On 18 June 2015 at 16:04, Jani Nikula wrote: > > > > Hi Dave, i915 fixes for drm-next/v4.2. > > > > BR, > > Jani. > > And my gcc says: > > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/i915/intel_display.c: > In function ‘__intel_set_mode’: > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/i915/intel_display.c:11850:14: > warning: ‘crtc_state’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > return state->mode_changed || state->active_changed; > ^ > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/i915/intel_display.c:11860:25: > note: ‘crtc_state’ was declared here > struct drm_crtc_state *crtc_state; > ^ > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/i915/intel_display.c:11874:6: > warning: ‘crtc’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > if (crtc != intel_encoder->base.crtc) > ^ > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/i915/intel_display.c:11859:19: > note: ‘crtc’ was declared here > struct drm_crtc *crtc; > ^ > > No idea if this is true, but I don't think I've seen it before now. > > gcc 5.1.1 on fedora 22 Yeah this is new with Ander's patches. gcc Doesn't know that we have at least 1 crtc and hence crtc&crtc are guaranteed to be initiliazed. I think you should be able to shut it up with But the entire Finland team is out of office (celebrating solstice), so might be better to wait for Monday for them to confirm. Otherwise just apply this fixup with my ack if you want to send out the merge window pull asap. Cheers, Daniel diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index e047105837c9..5ade250dc6d7 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -11856,8 +11856,8 @@ intel_modeset_update_state(struct drm_atomic_state *state) struct drm_device *dev = state->dev; struct drm_i915_private *dev_priv = dev->dev_private; struct intel_encoder *intel_encoder; - struct drm_crtc *crtc; - struct drm_crtc_state *crtc_state; + struct drm_crtc *crtc = NULL; + struct drm_crtc_state *crtc_state = NULL; struct drm_connector *connector; int i;