From patchwork Fri Jun 19 19:16:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 6647181 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8A7C59F1C1 for ; Fri, 19 Jun 2015 19:13:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B80B92096A for ; Fri, 19 Jun 2015 19:13:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 931882095F for ; Fri, 19 Jun 2015 19:13:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20EBD72148; Fri, 19 Jun 2015 12:13:29 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 9707472148 for ; Fri, 19 Jun 2015 12:13:28 -0700 (PDT) Received: by wicnd19 with SMTP id nd19so27469801wic.1 for ; Fri, 19 Jun 2015 12:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/Zyz6PL8uTfdJbm9HOSHTmdgqWR4uNaK1V3QsTbqYJM=; b=lNUzYntP//uYYNjAzJikGcOtA78iUZM3lSNXoyBArsuwOvY9p+V/oYHXlxgY9D+Gyg 3dxrjNy9/TKYM7VizEjW2NqY/IuyvdsPLNFds4wEZ2MhrJe5wtv6rO5aaBAzETpWtJgv sHoe9sJLucM/gAnLeewCeovU/uGKsogWzxag0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/Zyz6PL8uTfdJbm9HOSHTmdgqWR4uNaK1V3QsTbqYJM=; b=kBFA4DJ9COu+cfcEuuEPDLNOvrj5LxkparHC0LV/wfOAogN6KURlAaXCxt82IHdmHq irpXyUc1dRHDd19ouQ9als/b+DJXJ+XJoIVIxINso1lstqwd2W944wXSYgpvAnoED0QG a/WqaBqlUogxbgyCq+8iroFj1ewdtUjJF/c6aMKEDBEY9GAYPSscNT1cJLmZtzVCb+ac hGDEb/+zTuhkG/l8HzpHDMOCidnYUgJK4GVIe02oRK60Wm0EPpXD+IZFfrsGivNO8nNa yR26UsOT3dYd8Y2WHS9JZqVGm16GmG+mKuTUddj5QuF6mmBbAxzk97PcO2WlYbMIQCjz HRkw== X-Gm-Message-State: ALoCoQlDf8bZyCKnciv/lwC8WC/Xhe1Tkvl2rgC3da3PgFUZTEz/EVrNyQHL7YAqAmumrB+bbctq X-Received: by 10.194.95.132 with SMTP id dk4mr28714784wjb.88.1434741207452; Fri, 19 Jun 2015 12:13:27 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by mx.google.com with ESMTPSA id a8sm4946859wic.22.2015.06.19.12.13.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 19 Jun 2015 12:13:26 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Fri, 19 Jun 2015 21:16:09 +0200 Message-Id: <1434741369-28932-1-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1434732184-27338-1-git-send-email-daniel.vetter@ffwll.ch> References: <1434732184-27338-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Daniel Vetter , stable@vger.kernel.org Subject: [Intel-gfx] [PATCH] drm/i915: Officially give up on seqno coherency X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We've never figured out the magic trick to make irq vs. seqno updates coherent, only tricks to make it work. And since commit 094f9a54e35500739da185cdb78f2e92fc379458 Author: Chris Wilson Date: Wed Sep 25 17:34:55 2013 +0100 drm/i915: Fix __wait_seqno to use true infinite timeouts we automatically fall back to an irq augmented with polling scheme after the first missed interrupt. There's really nothing else we can do, hence tune down the message to informational level. It's still useful for users in case it reliable preceedes a hard system hang. v2: Use NOTICE since it might be of value for bug reports (Chris). Cc: Mark Janes Cc: Chris Wilson Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index e6bb72dca3ff..5072fb49367e 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -2946,8 +2946,8 @@ static void i915_hangcheck_elapsed(struct work_struct *work) /* Issue a wake-up to catch stuck h/w. */ if (!test_and_set_bit(ring->id, &dev_priv->gpu_error.missed_irq_rings)) { if (!(dev_priv->gpu_error.test_irq_rings & intel_ring_flag(ring))) - DRM_ERROR("Hangcheck timer elapsed... %s idle\n", - ring->name); + DRM_NOTICE("Hangcheck timer elapsed... %s idle\n", + ring->name); else DRM_INFO("Fake missed irq on %s\n", ring->name);