sna: Correct misspelled cacheing->caching in comments
diff mbox

Message ID 1435038342-3227-1-git-send-email-sedat.dilek@gmail.com
State New
Headers show

Commit Message

Sedat Dilek June 23, 2015, 5:45 a.m. UTC
I have seen this typo once and added an entry to codespell's dictionary.txt file.

$ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt

Comments

Chris Wilson June 24, 2015, 10:04 a.m. UTC | #1
On Tue, Jun 23, 2015 at 07:45:42AM +0200, Sedat Dilek wrote:
> I have seen this typo once and added an entry to codespell's dictionary.txt file.
> 
> $ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt
> --- /usr/share/codespell/dictionary.txt.orig    2015-06-09 20:49:25.000000000 +0200
> +++ /usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200
> @@ -625,6 +625,7 @@ burried->buried
>  busineses->business, businesses,
>  busness->business
>  bussiness->business
> +cacheing->caching
>  caculater->calculator
>  cacuses->caucuses
>  cahracters->characters
> 
> There some other places where this typo occurs:
> 
> [ src/sna/kgem.c ]
> 
>  298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo)
>  324:#define assert_cacheing(kgem, bo)
> 2455:  assert_cacheing(kgem, bo);
> 2841:  assert_cacheing(kgem, bo);
> 
> It's up to Chris what to do with this.

I just can't get paste reading 'caching' as two hard Cs and so it feels
weird.

commit f414ed4e40292e91e9c6850fb01a26334e6b43c7
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Jun 24 11:02:28 2015 +0100

    sna: Fix misspelling of "caching"
    
    Apply s/cacheing/caching/ because I am alone in my belief of how to
    spell cacheing correctly :)
    
    Suggested-by: Sedat Dilek <sedat.dilek@gmail.com>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks,
-Chris
Dave Gordon June 26, 2015, 2:51 p.m. UTC | #2
On 24/06/15 11:04, Chris Wilson wrote:
> On Tue, Jun 23, 2015 at 07:45:42AM +0200, Sedat Dilek wrote:
>> I have seen this typo once and added an entry to codespell's dictionary.txt file.
>>
>> $ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt
>> --- /usr/share/codespell/dictionary.txt.orig    2015-06-09 20:49:25.000000000 +0200
>> +++ /usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200
>> @@ -625,6 +625,7 @@ burried->buried
>>  busineses->business, businesses,
>>  busness->business
>>  bussiness->business
>> +cacheing->caching
>>  caculater->calculator
>>  cacuses->caucuses
>>  cahracters->characters
>>
>> There some other places where this typo occurs:
>>
>> [ src/sna/kgem.c ]
>>
>>  298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo)
>>  324:#define assert_cacheing(kgem, bo)
>> 2455:  assert_cacheing(kgem, bo);
>> 2841:  assert_cacheing(kgem, bo);
>>
>> It's up to Chris what to do with this.
> 
> I just can't get past reading 'caching' as two hard Cs and so it feels
> weird.

That would be Italian. Cache (and "cachet") come from French "cacher"
(to hide), so the "ch" is (almost) the same as in "chef" or "chauffeur".

We could switch to using the Esperanto spelling, "ka?i" and the
corresponding hardware term "ka?memoro" :)

.Dave.
Sedat Dilek July 2, 2015, 7:26 a.m. UTC | #3
On Wed, Jun 24, 2015 at 12:04 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Jun 23, 2015 at 07:45:42AM +0200, Sedat Dilek wrote:
>> I have seen this typo once and added an entry to codespell's dictionary.txt file.
>>
>> $ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt
>> --- /usr/share/codespell/dictionary.txt.orig    2015-06-09 20:49:25.000000000 +0200
>> +++ /usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200
>> @@ -625,6 +625,7 @@ burried->buried
>>  busineses->business, businesses,
>>  busness->business
>>  bussiness->business
>> +cacheing->caching
>>  caculater->calculator
>>  cacuses->caucuses
>>  cahracters->characters
>>
>> There some other places where this typo occurs:
>>
>> [ src/sna/kgem.c ]
>>
>>  298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo)
>>  324:#define assert_cacheing(kgem, bo)
>> 2455:  assert_cacheing(kgem, bo);
>> 2841:  assert_cacheing(kgem, bo);
>>
>> It's up to Chris what to do with this.
>
> I just can't get paste reading 'caching' as two hard Cs and so it feels
> weird.
>
> commit f414ed4e40292e91e9c6850fb01a26334e6b43c7
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Wed Jun 24 11:02:28 2015 +0100
>
>     sna: Fix misspelling of "caching"
>
>     Apply s/cacheing/caching/ because I am alone in my belief of how to
>     spell cacheing correctly :)
>
>     Suggested-by: Sedat Dilek <sedat.dilek@gmail.com>
>     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>

Thanks.

Just FYI... codespell got it, now.

commit b003c6167fdf441d2ba89534d402015723b66560
"Add misspelled cacheing->caching"

- sed@ -

[1] https://github.com/lucasdemarchi/codespell/commit/b003c6167fdf441d2ba89534d402015723b66560

Patch
diff mbox

--- /usr/share/codespell/dictionary.txt.orig    2015-06-09 20:49:25.000000000 +0200
+++ /usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200
@@ -625,6 +625,7 @@  burried->buried
 busineses->business, businesses,
 busness->business
 bussiness->business
+cacheing->caching
 caculater->calculator
 cacuses->caucuses
 cahracters->characters

There some other places where this typo occurs:

[ src/sna/kgem.c ]

 298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo)
 324:#define assert_cacheing(kgem, bo)
2455:  assert_cacheing(kgem, bo);
2841:  assert_cacheing(kgem, bo);

It's up to Chris what to do with this.

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 src/sna/sna_dri2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/sna/sna_dri2.c b/src/sna/sna_dri2.c
index 2cde0c6aa0dc..2a1f8475b735 100644
--- a/src/sna/sna_dri2.c
+++ b/src/sna/sna_dri2.c
@@ -228,7 +228,7 @@  sna_dri2_cache_bo(struct sna *sna,
 	if (!c)
 		goto err;
 
-	DBG(("%s: cacheing handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, bo->handle, name, flags, bo->active_scanout));
+	DBG(("%s: caching handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, bo->handle, name, flags, bo->active_scanout));
 
 	c->bo = bo;
 	c->name = name;
@@ -333,7 +333,7 @@  sna_dri2_get_back(struct sna *sna,
 			c->name = back->name;
 			c->flags = back->flags;
 			list_add(&c->link, &priv->cache);
-			DBG(("%s: cacheing handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, c->bo->handle, c->name, c->flags, c->bo->active_scanout));
+			DBG(("%s: caching handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, c->bo->handle, c->name, c->flags, c->bo->active_scanout));
 		}
 	} else {
 		if (&c->link != &priv->cache)