diff mbox

[05/23] drm/exynos: Kconfig: select DP if FIMD or DECON are selected

Message ID 1435095336-6196-6-git-send-email-gustavo@padovan.org (mailing list archive)
State New, archived
Headers show

Commit Message

Gustavo Padovan June 23, 2015, 9:35 p.m. UTC 
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

DP is required if either FIMD or DECON are selected so select it
automatically.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
 drivers/gpu/drm/exynos/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Andrzej Hajda June 24, 2015, 10 a.m. UTC | #1 
Hi Gustavo,

On 06/23/2015 11:35 PM, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> DP is required if either FIMD or DECON are selected so select it
> automatically.

It is not true, there are even SoCs with FIMD/DECON and without DP.

Regards
Andrzej

> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
>  drivers/gpu/drm/exynos/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
> index 8203283..2d86304 100644
> --- a/drivers/gpu/drm/exynos/Kconfig
> +++ b/drivers/gpu/drm/exynos/Kconfig
> @@ -20,6 +20,7 @@ config DRM_EXYNOS_FIMD
>  	bool "Exynos DRM FIMD"
>  	depends on DRM_EXYNOS && !FB_S3C
>  	select FB_MODE_HELPERS
> +	select DRM_EXYNOS_DP
>  	select MFD_SYSCON
>  	help
>  	  Choose this option if you want to use Exynos FIMD for DRM.
> @@ -28,6 +29,7 @@ config DRM_EXYNOS7_DECON
>  	bool "Exynos DRM DECON"
>  	depends on DRM_EXYNOS && !FB_S3C
>  	select FB_MODE_HELPERS
> +	select DRM_EXYNOS_DP
>  	help
>  	  Choose this option if you want to use Exynos DECON for DRM.
>  
> @@ -50,7 +52,7 @@ config DRM_EXYNOS_DSI
>  
>  config DRM_EXYNOS_DP
>  	bool "EXYNOS DRM DP driver support"
> -	depends on (DRM_EXYNOS_FIMD || DRM_EXYNOS7_DECON) && ARCH_EXYNOS && (DRM_PTN3460=n || DRM_PTN3460=y || DRM_PTN3460=DRM_EXYNOS)
> +	depends on ARCH_EXYNOS && (DRM_PTN3460=n || DRM_PTN3460=y || DRM_PTN3460=DRM_EXYNOS)
>  	default DRM_EXYNOS
>  	select DRM_PANEL
>  	help
>
Gustavo Padovan June 24, 2015, 1:59 p.m. UTC | #2 
Hi Andrzej,

2015-06-24 Andrzej Hajda <a.hajda@samsung.com>:

> Hi Gustavo,
> 
> On 06/23/2015 11:35 PM, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > DP is required if either FIMD or DECON are selected so select it
> > automatically.
> 
> It is not true, there are even SoCs with FIMD/DECON and without DP.

Right, I didn't know that. Let's just drop this patch then.

	Gustavo
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index 8203283..2d86304 100644
--- a/drivers/gpu/drm/exynos/Kconfig
+++ b/drivers/gpu/drm/exynos/Kconfig
@@ -20,6 +20,7 @@  config DRM_EXYNOS_FIMD
 	bool "Exynos DRM FIMD"
 	depends on DRM_EXYNOS && !FB_S3C
 	select FB_MODE_HELPERS
+	select DRM_EXYNOS_DP
 	select MFD_SYSCON
 	help
 	  Choose this option if you want to use Exynos FIMD for DRM.
@@ -28,6 +29,7 @@  config DRM_EXYNOS7_DECON
 	bool "Exynos DRM DECON"
 	depends on DRM_EXYNOS && !FB_S3C
 	select FB_MODE_HELPERS
+	select DRM_EXYNOS_DP
 	help
 	  Choose this option if you want to use Exynos DECON for DRM.
 
@@ -50,7 +52,7 @@  config DRM_EXYNOS_DSI
 
 config DRM_EXYNOS_DP
 	bool "EXYNOS DRM DP driver support"
-	depends on (DRM_EXYNOS_FIMD || DRM_EXYNOS7_DECON) && ARCH_EXYNOS && (DRM_PTN3460=n || DRM_PTN3460=y || DRM_PTN3460=DRM_EXYNOS)
+	depends on ARCH_EXYNOS && (DRM_PTN3460=n || DRM_PTN3460=y || DRM_PTN3460=DRM_EXYNOS)
 	default DRM_EXYNOS
 	select DRM_PANEL
 	help