[8/8] inode: don't softlockup when evicting inodes
diff mbox

Message ID 1435116242-27495-9-git-send-email-jbacik@fb.com
State New
Headers show

Commit Message

Josef Bacik June 24, 2015, 3:24 a.m. UTC
On a box with a lot of ram (148gb) I can make the box softlockup after running
an fs_mark job that creates hundreds of millions of empty files.  This is
because we never generate enough memory pressure to keep the number of inodes on
our unused list low, so when we go to unmount we have to evict ~100 million
inodes.  This makes one processor a very unhappy person, so add a cond_resched()
in dispose_list() and if we need a resched when processing the s_inodes list do
that and run dispose_list() on what we've currently culled.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fb.com>
Reviewed-by: Jan Kara <jack@suse.cz>
 fs/inode.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff mbox

diff --git a/fs/inode.c b/fs/inode.c
index 8f00557..3cdd79c 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -575,6 +575,7 @@  static void dispose_list(struct list_head *head)
+		cond_resched();
@@ -592,6 +593,7 @@  void evict_inodes(struct super_block *sb)
 	struct inode *inode, *next;
 	list_for_each_entry_safe(inode, next, &sb->s_inodes, i_sb_list) {
 		if (atomic_read(&inode->i_count))
@@ -607,6 +609,18 @@  void evict_inodes(struct super_block *sb)
 		list_add(&inode->i_lru, &dispose);
+		/*
+		 * We can have a ton of inodes to evict at unmount time given
+		 * enough memory, check to see if we need to go to sleep for a
+		 * bit so we don't livelock.
+		 */
+		if (need_resched()) {
+			spin_unlock(&sb->s_inode_list_lock);
+			cond_resched();
+			dispose_list(&dispose);
+			goto again;
+		}