diff mbox

[5/7,media] omap3isp: remove unused var

Message ID 7a9327cd8788da75b44d3bafb058bcfd6ae34319.1435142906.git.mchehab@osg.samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab June 24, 2015, 10:49 a.m. UTC 
drivers/media/platform/omap3isp/isppreview.c:932:6: warning: variable ‘features’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

Comments

Laurent Pinchart June 25, 2015, 9:52 p.m. UTC | #1 
Hi Mauro,

On Wednesday 24 June 2015 07:49:09 Mauro Carvalho Chehab wrote:
> drivers/media/platform/omap3isp/isppreview.c:932:6: warning: variable
> ‘features’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

On a side note, I'd appreciate if you could wait a couple of days for review 
before committing patches to the media_tree master branch.

Or maybe process pending pull requests for the same driver before fast-
tracking your own patches ;-)

> diff --git a/drivers/media/platform/omap3isp/isppreview.c
> b/drivers/media/platform/omap3isp/isppreview.c index
> 15cb254ccc39..13803270d104 100644
> --- a/drivers/media/platform/omap3isp/isppreview.c
> +++ b/drivers/media/platform/omap3isp/isppreview.c
> @@ -929,14 +929,10 @@ static void preview_setup_hw(struct isp_prev_device
> *prev, u32 update, u32 active)
>  {
>  	unsigned int i;
> -	u32 features;
> 
>  	if (update == 0)
>  		return;
> 
> -	features = (prev->params.params[0].features & active)
> -		 | (prev->params.params[1].features & ~active);
> -
>  	for (i = 0; i < ARRAY_SIZE(update_attrs); i++) {
>  		const struct preview_update *attr = &update_attrs[i];
>  		struct prev_params *params;
diff mbox

Patch

diff --git a/drivers/media/platform/omap3isp/isppreview.c b/drivers/media/platform/omap3isp/isppreview.c
index 15cb254ccc39..13803270d104 100644
--- a/drivers/media/platform/omap3isp/isppreview.c
+++ b/drivers/media/platform/omap3isp/isppreview.c
@@ -929,14 +929,10 @@  static void preview_setup_hw(struct isp_prev_device *prev, u32 update,
 			     u32 active)
 {
 	unsigned int i;
-	u32 features;
 
 	if (update == 0)
 		return;
 
-	features = (prev->params.params[0].features & active)
-		 | (prev->params.params[1].features & ~active);
-
 	for (i = 0; i < ARRAY_SIZE(update_attrs); i++) {
 		const struct preview_update *attr = &update_attrs[i];
 		struct prev_params *params;