Message ID | 1435180719-12000-2-git-send-email-benoit.canet@nodalink.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 06/24/2015 04:18 PM, Benoît Canet wrote: > ceph_tcp_sendpage already does the work of mapping/unmapping > the zero page if needed. > > Signed-off-by: Benoît Canet <benoit.canet@nodalink.com> This looks good. Reviewed-by: Alex Elder <elder@linaro.org> > --- > net/ceph/messenger.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c > index 967080a..38f06a4 100644 > --- a/net/ceph/messenger.c > +++ b/net/ceph/messenger.c > @@ -278,7 +278,6 @@ static void _ceph_msgr_exit(void) > ceph_msgr_slab_exit(); > > BUG_ON(zero_page == NULL); > - kunmap(zero_page); > page_cache_release(zero_page); > zero_page = NULL; > } > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jun 25, 2015 at 3:35 AM, Alex Elder <elder@ieee.org> wrote: > On 06/24/2015 04:18 PM, Benoît Canet wrote: >> >> ceph_tcp_sendpage already does the work of mapping/unmapping >> the zero page if needed. >> >> Signed-off-by: Benoît Canet <benoit.canet@nodalink.com> > > > This looks good. > > Reviewed-by: Alex Elder <elder@linaro.org> Applied. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c index 967080a..38f06a4 100644 --- a/net/ceph/messenger.c +++ b/net/ceph/messenger.c @@ -278,7 +278,6 @@ static void _ceph_msgr_exit(void) ceph_msgr_slab_exit(); BUG_ON(zero_page == NULL); - kunmap(zero_page); page_cache_release(zero_page); zero_page = NULL; }
ceph_tcp_sendpage already does the work of mapping/unmapping the zero page if needed. Signed-off-by: Benoît Canet <benoit.canet@nodalink.com> --- net/ceph/messenger.c | 1 - 1 file changed, 1 deletion(-)