thermal: Switch mode to enabled once the cooling device is bound
diff mbox

Message ID 1435236635-20830-1-git-send-email-j-keerthy@ti.com
State New
Headers show

Commit Message

Keerthy June 25, 2015, 12:50 p.m. UTC
Currently mode is still disabled even after the cooling device is bound
to the appropriate device. Hence changing the mode to enabled as soon as
the cooling device is registered successfully.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 drivers/thermal/of-thermal.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Nishanth Menon June 25, 2015, 5:35 p.m. UTC | #1
On 06/25/2015 07:50 AM, Keerthy wrote:
> Currently mode is still disabled even after the cooling device is bound
> to the appropriate device. Hence changing the mode to enabled as soon as
> the cooling device is registered successfully.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/thermal/of-thermal.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 04b1be7..bc84485 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -163,6 +163,9 @@ static int of_thermal_bind(struct thermal_zone_device *thermal,
>  		}
>  	}
>  
> +	/* Now that cooling device is bound enable the thermal device*/
> +	data->mode = THERMAL_DEVICE_ENABLED;
> +
>  	return 0;
>  }
>  
> 
This makes sense to me rather than waiting for userspace to enable the
zone -(by which time we might have hit catastrophic thermal events
which may have been prevented if we had the zones enabled and cooling
devices functional.
Javi Merino June 26, 2015, 11:17 a.m. UTC | #2
On Thu, Jun 25, 2015 at 01:50:35PM +0100, Keerthy wrote:
> Currently mode is still disabled even after the cooling device is bound
> to the appropriate device. Hence changing the mode to enabled as soon as
> the cooling device is registered successfully.

This should have been fixed by 528012c1f437 ("thermal: of: Enable
thermal_zoneX when sensor is correctly added"), which was merged in
4.0.  With this, the thermal zone is enabled when it is registered.
Can you elaborate on why is this needed?

Cheers,
Javi

> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/thermal/of-thermal.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 04b1be7..bc84485 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -163,6 +163,9 @@ static int of_thermal_bind(struct thermal_zone_device *thermal,
>  		}
>  	}
>  
> +	/* Now that cooling device is bound enable the thermal device*/
> +	data->mode = THERMAL_DEVICE_ENABLED;
> +
>  	return 0;
>  }
>  
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keerthy June 26, 2015, 11:49 a.m. UTC | #3
On Friday 26 June 2015 04:47 PM, Javi Merino wrote:
> On Thu, Jun 25, 2015 at 01:50:35PM +0100, Keerthy wrote:
>> Currently mode is still disabled even after the cooling device is bound
>> to the appropriate device. Hence changing the mode to enabled as soon as
>> the cooling device is registered successfully.
>
> This should have been fixed by 528012c1f437 ("thermal: of: Enable
> thermal_zoneX when sensor is correctly added"), which was merged in
> 4.0.  With this, the thermal zone is enabled when it is registered.
> Can you elaborate on why is this needed?

Thanks for pointing out. This takes care of enabling by default.

Cheers,
Keerthy
>
> Cheers,
> Javi
>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>   drivers/thermal/of-thermal.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
>> index 04b1be7..bc84485 100644
>> --- a/drivers/thermal/of-thermal.c
>> +++ b/drivers/thermal/of-thermal.c
>> @@ -163,6 +163,9 @@ static int of_thermal_bind(struct thermal_zone_device *thermal,
>>   		}
>>   	}
>>
>> +	/* Now that cooling device is bound enable the thermal device*/
>> +	data->mode = THERMAL_DEVICE_ENABLED;
>> +
>>   	return 0;
>>   }
>>
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
index 04b1be7..bc84485 100644
--- a/drivers/thermal/of-thermal.c
+++ b/drivers/thermal/of-thermal.c
@@ -163,6 +163,9 @@  static int of_thermal_bind(struct thermal_zone_device *thermal,
 		}
 	}
 
+	/* Now that cooling device is bound enable the thermal device*/
+	data->mode = THERMAL_DEVICE_ENABLED;
+
 	return 0;
 }