diff mbox

[1/1] gpu/drm: use kzalloc for allocating one thing

Message ID 1435299850-48390-1-git-send-email-maninder1.s@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Maninder Singh June 26, 2015, 6:24 a.m. UTC 
Use kzalloc rather than kcalloc(1.. for allocating
one thing.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Vaneet Narang <v.narang@samsung.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Vetter June 26, 2015, 7:34 a.m. UTC | #1 
On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
> Use kzalloc rather than kcalloc(1.. for allocating
> one thing.
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Vaneet Narang <v.narang@samsung.com>

Applied to drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index d3706a4..dd3415d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -674,7 +674,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm)
>  		return 0;
>  
>  	if (gtt && gtt->userptr) {
> -		ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL);
> +		ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
>  		if (!ttm->sg)
>  			return -ENOMEM;
>  
> -- 
> 1.7.9.5
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
Daniel Vetter June 26, 2015, 7:37 a.m. UTC | #2 
On Fri, Jun 26, 2015 at 09:34:43AM +0200, Daniel Vetter wrote:
> On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
> > Use kzalloc rather than kcalloc(1.. for allocating
> > one thing.
> > 
> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> 
> Applied to drm-misc, thanks.

And dropped again since I didn't realize this is for amdgpu and not core
drm.
-Daniel
Christian König June 26, 2015, 7:40 a.m. UTC | #3 
On 26.06.2015 09:37, Daniel Vetter wrote:
> On Fri, Jun 26, 2015 at 09:34:43AM +0200, Daniel Vetter wrote:
>> On Fri, Jun 26, 2015 at 11:54:10AM +0530, Maninder Singh wrote:
>>> Use kzalloc rather than kcalloc(1.. for allocating
>>> one thing.
>>>
>>> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>>> Reviewed-by: Vaneet Narang <v.narang@samsung.com>
>> Applied to drm-misc, thanks.
> And dropped again since I didn't realize this is for amdgpu and not core
> drm.

I was just about to complain on the confusing patch subject :)

So please fix the subject lines of both your patches to something like 
"drm/amdgpu:" and send them out again.

With that fixed both patches are Reviewed-by: Christian König 
<christian.koenig@amd.com>

Regards,
Christian.

> -Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index d3706a4..dd3415d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -674,7 +674,7 @@  static int amdgpu_ttm_tt_populate(struct ttm_tt *ttm)
 		return 0;
 
 	if (gtt && gtt->userptr) {
-		ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL);
+		ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
 		if (!ttm->sg)
 			return -ENOMEM;