From patchwork Thu Jun 25 12:00:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 6678921 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 63CB59F39B for ; Fri, 26 Jun 2015 08:43:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3233420702 for ; Fri, 26 Jun 2015 08:43:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06627206E8 for ; Fri, 26 Jun 2015 08:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751637AbbFZIne (ORCPT ); Fri, 26 Jun 2015 04:43:34 -0400 Received: from mail.kernel.org ([198.145.29.136]:52560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbbFZIna (ORCPT ); Fri, 26 Jun 2015 04:43:30 -0400 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6D862206F3; Fri, 26 Jun 2015 08:43:29 +0000 (UTC) Received: from debian3.lan (bl13-155-180.dsl.telepac.pt [85.246.155.180]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA1A9206E8; Fri, 26 Jun 2015 08:43:27 +0000 (UTC) From: fdmanana@kernel.org To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe Manana Subject: [PATCH v2] fstests: generic test for fsync after file truncations Date: Thu, 25 Jun 2015 13:00:24 +0100 Message-Id: <1435233624-32338-1-git-send-email-fdmanana@kernel.org> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1435202295-23619-1-git-send-email-fdmanana@kernel.org> References: <1435202295-23619-1-git-send-email-fdmanana@kernel.org> X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DATE_IN_PAST_12_24, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Filipe Manana Test that if we truncate a file to a smaller size, then truncate it to its original size or a larger size, then fsyncing it and a power failure happens, the file will have the range [first_truncate_size, last_size[ with all bytes having a value of 0x00 if we read it the next time the filesystem is mounted. This test is motivated by a bug found in btrfs, which is fixed by a patch titled: "Btrfs: fix fsync after truncate when no_holes feature is enabled" Tested against ext3/4, xfs, btrfs (with and without the fix, and with the no_holes feature disabled), f2fs, reiserfs and nilfs2. All filesystems pass the test except for unpatched btrfs with the no_holes feature enabled (as expected) and f2fs. Both produce the following file contents that differ from the golden output: File foo content after log replay: 0000000 aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa * 0200000 bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb * 0372000 File bar content after log replay: 0000000 ee ee ee ee ee ee ee ee ee ee ee ee ee ee ee ee * 0200000 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff * 0372000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 * 0772000 Signed-off-by: Filipe Manana Reviewed-by: Eryu Guan --- V2: Added missing call to _require_metadata_journaling and Eryu's reviewed-by tag. tests/generic/095 | 117 ++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/095.out | 19 ++++++++ tests/generic/group | 1 + 3 files changed, 137 insertions(+) create mode 100755 tests/generic/095 create mode 100644 tests/generic/095.out diff --git a/tests/generic/095 b/tests/generic/095 new file mode 100755 index 0000000..95f8b44 --- /dev/null +++ b/tests/generic/095 @@ -0,0 +1,117 @@ +#! /bin/bash +# FSQA Test No. 095 +# +# Test that if we truncate a file to a smaller size, then truncate it to its +# original size or a larger size, then fsyncing it and a power failure happens, +# the file will have the range [first_truncate_size, last_size[ with all bytes +# having a value of 0x00 if we read it the next time the filesystem is mounted. +# +# This test is motivated by a bug found in btrfs. +# +#----------------------------------------------------------------------- +# +# Copyright (C) 2015 SUSE Linux Products GmbH. All Rights Reserved. +# Author: Filipe Manana +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + _cleanup_flakey + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/dmflakey + +# real QA test starts here +_need_to_be_root +_supported_fs generic +_supported_os Linux +_require_scratch +_require_dm_flakey +_require_metadata_journaling $SCRATCH_DEV + +# This test was motivated by an issue found in btrfs when the btrfs no-holes +# feature is enabled (introduced in kernel 3.14). So enable the feature if the +# fs being tested is btrfs. +if [ $FSTYP == "btrfs" ]; then + _require_btrfs_fs_feature "no_holes" + _require_btrfs_mkfs_feature "no-holes" + MKFS_OPTIONS="$MKFS_OPTIONS -O no-holes" +fi + +rm -f $seqres.full + +_scratch_mkfs >>$seqres.full 2>&1 +_init_flakey +_mount_flakey + +# Create our test files and make sure everything is durably persisted. +$XFS_IO_PROG -f -c "pwrite -S 0xaa 0 64K" \ + -c "pwrite -S 0xbb 64K 61K" \ + $SCRATCH_MNT/foo | _filter_xfs_io +$XFS_IO_PROG -f -c "pwrite -S 0xee 0 64K" \ + -c "pwrite -S 0xff 64K 61K" \ + $SCRATCH_MNT/bar | _filter_xfs_io +sync + +# Now truncate our file foo to a smaller size (64Kb) and then truncate it to the +# size it had before the shrinking truncate (125Kb). Then fsync our file. If a +# power failure happens after the fsync, we expect our file to have a size of +# 125Kb, with the first 64Kb of data having the value 0xaa and the second 61Kb +# of data having the value 0x00. +$XFS_IO_PROG -c "truncate 64K" \ + -c "truncate 125K" \ + -c "fsync" \ + $SCRATCH_MNT/foo + +# Do something similar to our file bar, but the first truncation sets the file +# size to 0 and the second truncation expands the size to the double of what it +# was initially. +$XFS_IO_PROG -c "truncate 0" \ + -c "truncate 253K" \ + -c "fsync" \ + $SCRATCH_MNT/bar + +_load_flakey_table $FLAKEY_DROP_WRITES +_unmount_flakey + +# Allow writes again, mount to trigger log replay and validate file contents. +_load_flakey_table $FLAKEY_ALLOW_WRITES +_mount_flakey + +# We expect foo to have a size of 125Kb, the first 64Kb of data all having the +# value 0xaa and the remaining 61Kb to be a hole (all bytes with value 0x00). +echo "File foo content after log replay:" +od -t x1 $SCRATCH_MNT/foo + +# We expect bar to have a size of 253Kb and no extents (any byte read from bar +# has the value 0x00). +echo "File bar content after log replay:" +od -t x1 $SCRATCH_MNT/bar + +status=0 +exit diff --git a/tests/generic/095.out b/tests/generic/095.out new file mode 100644 index 0000000..89586fe --- /dev/null +++ b/tests/generic/095.out @@ -0,0 +1,19 @@ +QA output created by 095 +wrote 65536/65536 bytes at offset 0 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +wrote 62464/62464 bytes at offset 65536 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +wrote 65536/65536 bytes at offset 0 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +wrote 62464/62464 bytes at offset 65536 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +File foo content after log replay: +0000000 aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa +* +0200000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +* +0372000 +File bar content after log replay: +0000000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +* +0772000 diff --git a/tests/generic/group b/tests/generic/group index c14ddb9..1f1a0b0 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -97,6 +97,7 @@ 092 auto quick prealloc 093 attr cap udf auto 094 auto quick metadata +095 auto quick metadata 097 udf auto 099 udf auto 100 udf auto