hpfs: Remove unessary cast
diff mbox

Message ID alpine.DEB.2.00.1506281518020.29365@leontynka
State New
Headers show

Commit Message

Mikulas Patocka June 28, 2015, 1:18 p.m. UTC
From: Firo Yang <firogm@gmail.com>
Date: Thu, 23 Apr 2015 17:28:45 +0800

Avoid a pointless kmem_cache_alloc() return value cast in
fs/hpfs/super.c::hpfs_alloc_inode()

Signed-off-by: Firo Yang <firogm@gmail.com>
Signed-off-by: Mikulas Patocka <mikulas@twibright.com>
---
 fs/hpfs/super.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Sohny Thomas June 29, 2015, 8:19 a.m. UTC | #1
IMHO I think its better of being cast since you do have another pointer 
inside the struct.

On 28-06-2015 18:48, Mikulas Patocka wrote:
> From: Firo Yang <firogm@gmail.com>
> Date: Thu, 23 Apr 2015 17:28:45 +0800
>
> Avoid a pointless kmem_cache_alloc() return value cast in
> fs/hpfs/super.c::hpfs_alloc_inode()
>
> Signed-off-by: Firo Yang <firogm@gmail.com>
> Signed-off-by: Mikulas Patocka <mikulas@twibright.com>
> ---
>   fs/hpfs/super.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-4.1/fs/hpfs/super.c
> ===================================================================
> --- linux-4.1.orig/fs/hpfs/super.c	2015-06-22 20:17:54.000000000 +0200
> +++ linux-4.1/fs/hpfs/super.c	2015-06-22 21:27:59.000000000 +0200
> @@ -238,7 +238,7 @@ static struct kmem_cache * hpfs_inode_ca
>   static struct inode *hpfs_alloc_inode(struct super_block *sb)
>   {
>   	struct hpfs_inode_info *ei;
> -	ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
> +	ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
>   	if (!ei)
>   		return NULL;
>   	ei->vfs_inode.i_version = 1;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

Index: linux-4.1/fs/hpfs/super.c
===================================================================
--- linux-4.1.orig/fs/hpfs/super.c	2015-06-22 20:17:54.000000000 +0200
+++ linux-4.1/fs/hpfs/super.c	2015-06-22 21:27:59.000000000 +0200
@@ -238,7 +238,7 @@  static struct kmem_cache * hpfs_inode_ca
 static struct inode *hpfs_alloc_inode(struct super_block *sb)
 {
 	struct hpfs_inode_info *ei;
-	ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
+	ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
 	if (!ei)
 		return NULL;
 	ei->vfs_inode.i_version = 1;