| Message ID | 1436150666-106766-1-git-send-email-libin.yang@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e828b23734bfebe30e95964302bbb801d02fddf6 |
| Headers | show |
At Mon, 6 Jul 2015 10:44:26 +0800, libin.yang@intel.com wrote: > > From: Libin Yang <libin.yang@intel.com> > > This patch adds codec ID (0x8086280a) and module alias for Broxton > display codec. > > Signed-off-by: Libin Yang <libin.yang@intel.com> I applied this now, but don't you need the workaround for haswell+? thanks, Takashi > --- > sound/pci/hda/patch_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > index 2f24338..9515891 100644 > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -3527,6 +3527,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = { > { .id = 0x80862807, .name = "Haswell HDMI", .patch = patch_generic_hdmi }, > { .id = 0x80862808, .name = "Broadwell HDMI", .patch = patch_generic_hdmi }, > { .id = 0x80862809, .name = "Skylake HDMI", .patch = patch_generic_hdmi }, > +{ .id = 0x8086280a, .name = "Broxton HDMI", .patch = patch_generic_hdmi }, > { .id = 0x80862880, .name = "CedarTrail HDMI", .patch = patch_generic_hdmi }, > { .id = 0x80862882, .name = "Valleyview2 HDMI", .patch = patch_generic_hdmi }, > { .id = 0x80862883, .name = "Braswell HDMI", .patch = patch_generic_hdmi }, > @@ -3591,6 +3592,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862806"); > MODULE_ALIAS("snd-hda-codec-id:80862807"); > MODULE_ALIAS("snd-hda-codec-id:80862808"); > MODULE_ALIAS("snd-hda-codec-id:80862809"); > +MODULE_ALIAS("snd-hda-codec-id:8086280a"); > MODULE_ALIAS("snd-hda-codec-id:80862880"); > MODULE_ALIAS("snd-hda-codec-id:80862882"); > MODULE_ALIAS("snd-hda-codec-id:80862883"); > -- > 1.9.1 >
Hi Takashi, > -----Original Message----- > From: Takashi Iwai [mailto:tiwai@suse.de] > Sent: Monday, July 06, 2015 4:38 PM > To: Yang, Libin > Cc: alsa-devel@alsa-project.org > Subject: Re: [PATCH] ALSA: hda - add codec ID for Broxton display > audio codec > > At Mon, 6 Jul 2015 10:44:26 +0800, > libin.yang@intel.com wrote: > > > > From: Libin Yang <libin.yang@intel.com> > > > > This patch adds codec ID (0x8086280a) and module alias for Broxton > > display codec. > > > > Signed-off-by: Libin Yang <libin.yang@intel.com> > > I applied this now, but don't you need the workaround for haswell+? Yes, I believe we need the workaround. As we currently don't have a platform to test, I do not make the workaround patch. I will make the patch when I get a platform to test. > > > thanks, > > Takashi > > > --- > > sound/pci/hda/patch_hdmi.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/sound/pci/hda/patch_hdmi.c > b/sound/pci/hda/patch_hdmi.c > > index 2f24338..9515891 100644 > > --- a/sound/pci/hda/patch_hdmi.c > > +++ b/sound/pci/hda/patch_hdmi.c > > @@ -3527,6 +3527,7 @@ static const struct hda_codec_preset > snd_hda_preset_hdmi[] = { > > { .id = 0x80862807, .name = "Haswell HDMI", .patch = > patch_generic_hdmi }, > > { .id = 0x80862808, .name = "Broadwell HDMI", .patch = > patch_generic_hdmi }, > > { .id = 0x80862809, .name = "Skylake HDMI", .patch = > patch_generic_hdmi }, > > +{ .id = 0x8086280a, .name = "Broxton HDMI", .patch = > patch_generic_hdmi }, > > { .id = 0x80862880, .name = "CedarTrail HDMI", .patch = > patch_generic_hdmi }, > > { .id = 0x80862882, .name = "Valleyview2 HDMI", .patch = > patch_generic_hdmi }, > > { .id = 0x80862883, .name = "Braswell HDMI", .patch = > patch_generic_hdmi }, > > @@ -3591,6 +3592,7 @@ MODULE_ALIAS("snd-hda-codec- > id:80862806"); > > MODULE_ALIAS("snd-hda-codec-id:80862807"); > > MODULE_ALIAS("snd-hda-codec-id:80862808"); > > MODULE_ALIAS("snd-hda-codec-id:80862809"); > > +MODULE_ALIAS("snd-hda-codec-id:8086280a"); > > MODULE_ALIAS("snd-hda-codec-id:80862880"); > > MODULE_ALIAS("snd-hda-codec-id:80862882"); > > MODULE_ALIAS("snd-hda-codec-id:80862883"); > > -- > > 1.9.1 > >
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 2f24338..9515891 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -3527,6 +3527,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = { { .id = 0x80862807, .name = "Haswell HDMI", .patch = patch_generic_hdmi }, { .id = 0x80862808, .name = "Broadwell HDMI", .patch = patch_generic_hdmi }, { .id = 0x80862809, .name = "Skylake HDMI", .patch = patch_generic_hdmi }, +{ .id = 0x8086280a, .name = "Broxton HDMI", .patch = patch_generic_hdmi }, { .id = 0x80862880, .name = "CedarTrail HDMI", .patch = patch_generic_hdmi }, { .id = 0x80862882, .name = "Valleyview2 HDMI", .patch = patch_generic_hdmi }, { .id = 0x80862883, .name = "Braswell HDMI", .patch = patch_generic_hdmi }, @@ -3591,6 +3592,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862806"); MODULE_ALIAS("snd-hda-codec-id:80862807"); MODULE_ALIAS("snd-hda-codec-id:80862808"); MODULE_ALIAS("snd-hda-codec-id:80862809"); +MODULE_ALIAS("snd-hda-codec-id:8086280a"); MODULE_ALIAS("snd-hda-codec-id:80862880"); MODULE_ALIAS("snd-hda-codec-id:80862882"); MODULE_ALIAS("snd-hda-codec-id:80862883");