From patchwork Mon Jul 6 14:20:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 6725031 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 543129F319 for ; Mon, 6 Jul 2015 14:21:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8502D206CC for ; Mon, 6 Jul 2015 14:21:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id AC1FB20584 for ; Mon, 6 Jul 2015 14:21:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DE4FC6E8A7; Mon, 6 Jul 2015 07:21:36 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com [209.85.220.181]) by gabe.freedesktop.org (Postfix) with ESMTPS id D34256E8A7 for ; Mon, 6 Jul 2015 07:21:35 -0700 (PDT) Received: by qkbp125 with SMTP id p125so117847216qkb.2 for ; Mon, 06 Jul 2015 07:21:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gvoGC9Ljzyt+ueBKRCRth9+HhhxjhCgnbZbuEIYsHoc=; b=M/7sKepnepxeehEO9Jl0q+iK+UpMCt99WxyaPnzRgzV5TP9s2b8P3jYC5OkOZy6glB szH8L34J9GmXn/RPkkaaYUD+PdT5lQSw8nqkAB0n25trdltqZs0wX3Dmrg3rTiRPgf5f ZPMa0QaT1wRUJHlyVqf4PVy+LeTfDOu8kMjPEPovjGtZ7e5ZDwRJ43poraohmLvKfTVk qei/1/fGnfJcBijJV5EylDs2AIDmZPEhfUSsOcqeh8tIYX0zS77Og0zcZkTOXTnawJNw eWyHevZRxA/a9L/n7GYSj1pzX5ft0uxzXBjZxKA3axfLlq4QfY5M1dXhQK+EI5xcdAn3 eJ9Q== X-Received: by 10.141.28.195 with SMTP id f186mr77516099qhe.31.1436192495109; Mon, 06 Jul 2015 07:21:35 -0700 (PDT) Received: from jade.localdomain ([191.255.48.48]) by mx.google.com with ESMTPSA id f207sm1707424qhc.41.2015.07.06.07.21.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jul 2015 07:21:34 -0700 (PDT) From: Gustavo Padovan To: linux-samsung-soc@vger.kernel.org Subject: [PATCH v2 20/23] drm/exynos: remove exynos_encoder's .commit() op Date: Mon, 6 Jul 2015 11:20:21 -0300 Message-Id: <1436192424-18194-21-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1436192424-18194-1-git-send-email-gustavo@padovan.org> References: <1436192424-18194-1-git-send-email-gustavo@padovan.org> Cc: tjakobi@math.uni-bielefeld.de, Gustavo Padovan , dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan .commit() is not used anymore, Exynos encoders now follow the .enable()/.disable() semantics from drm atomic core, so remove this callback. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 -- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h index 615b635..b940bcca 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h @@ -87,7 +87,6 @@ struct exynos_drm_plane { * would be called by encoder->mode_set(). * @enable: display device on. * @disable: display device off. - * @commit: apply changes to hw */ struct exynos_drm_encoder; struct exynos_drm_encoder_ops { @@ -100,7 +99,6 @@ struct exynos_drm_encoder_ops { struct drm_display_mode *mode); void (*enable)(struct exynos_drm_encoder *encoder); void (*disable)(struct exynos_drm_encoder *encoder); - void (*commit)(struct exynos_drm_encoder *encoder); }; /* diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c index b9a1c93..ce7b97e 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c @@ -56,9 +56,6 @@ static void exynos_drm_encoder_enable(struct drm_encoder *encoder) if (exynos_encoder->ops->enable) exynos_encoder->ops->enable(exynos_encoder); - - if (exynos_encoder->ops->commit) - exynos_encoder->ops->commit(exynos_encoder); } static void exynos_drm_encoder_disable(struct drm_encoder *encoder)