pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ
diff mbox

Message ID 1436195510-23880-1-git-send-email-grygorii.strashko@ti.com
State New
Headers show

Commit Message

Grygorii Strashko July 6, 2015, 3:11 p.m. UTC
On DRA7 there is one pinctrl domain (dra7_pmx_core) and
PRCM wake-up IRQ is not shared, so remove quirk.

Cc: Nishanth Menon <nm@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 drivers/pinctrl/pinctrl-single.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Tony Lindgren July 6, 2015, 3:25 p.m. UTC | #1
* Grygorii Strashko <grygorii.strashko@ti.com> [150706 08:14]:
> On DRA7 there is one pinctrl domain (dra7_pmx_core) and
> PRCM wake-up IRQ is not shared, so remove quirk.
> 
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
>  drivers/pinctrl/pinctrl-single.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index 0b8d480..9b24b343 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -1983,7 +1983,6 @@ static const struct pcs_soc_data pinctrl_single_omap_wkup = {
>  };
>  
>  static const struct pcs_soc_data pinctrl_single_dra7 = {
> -	.flags = PCS_QUIRK_SHARED_IRQ,
>  	.irq_enable_mask = (1 << 24),	/* WAKEUPENABLE */
>  	.irq_status_mask = (1 << 25),	/* WAKEUPEVENT */
>  };

Tero, care to take a look at this one and ack if OK?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tero Kristo July 7, 2015, 7:23 a.m. UTC | #2
On 07/06/2015 06:25 PM, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [150706 08:14]:
>> On DRA7 there is one pinctrl domain (dra7_pmx_core) and
>> PRCM wake-up IRQ is not shared, so remove quirk.
>>
>> Cc: Nishanth Menon <nm@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>>   drivers/pinctrl/pinctrl-single.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
>> index 0b8d480..9b24b343 100644
>> --- a/drivers/pinctrl/pinctrl-single.c
>> +++ b/drivers/pinctrl/pinctrl-single.c
>> @@ -1983,7 +1983,6 @@ static const struct pcs_soc_data pinctrl_single_omap_wkup = {
>>   };
>>
>>   static const struct pcs_soc_data pinctrl_single_dra7 = {
>> -	.flags = PCS_QUIRK_SHARED_IRQ,
>>   	.irq_enable_mask = (1 << 24),	/* WAKEUPENABLE */
>>   	.irq_status_mask = (1 << 25),	/* WAKEUPEVENT */
>>   };
>
> Tero, care to take a look at this one and ack if OK?

Looks fine to me.

Acked-by: Tero Kristo <t-kristo@ti.com>

>
> Regards,
>
> Tony
>

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren July 7, 2015, 7:43 a.m. UTC | #3
* Tero Kristo <t-kristo@ti.com> [150707 00:25]:
> On 07/06/2015 06:25 PM, Tony Lindgren wrote:
> >* Grygorii Strashko <grygorii.strashko@ti.com> [150706 08:14]:
> >>On DRA7 there is one pinctrl domain (dra7_pmx_core) and
> >>PRCM wake-up IRQ is not shared, so remove quirk.
> >>
> >>Cc: Nishanth Menon <nm@ti.com>
> >>Cc: Tony Lindgren <tony@atomide.com>
> >>Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
> >>Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> >>---
> >>  drivers/pinctrl/pinctrl-single.c | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >>diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> >>index 0b8d480..9b24b343 100644
> >>--- a/drivers/pinctrl/pinctrl-single.c
> >>+++ b/drivers/pinctrl/pinctrl-single.c
> >>@@ -1983,7 +1983,6 @@ static const struct pcs_soc_data pinctrl_single_omap_wkup = {
> >>  };
> >>
> >>  static const struct pcs_soc_data pinctrl_single_dra7 = {
> >>-	.flags = PCS_QUIRK_SHARED_IRQ,
> >>  	.irq_enable_mask = (1 << 24),	/* WAKEUPENABLE */
> >>  	.irq_status_mask = (1 << 25),	/* WAKEUPEVENT */
> >>  };
> >
> >Tero, care to take a look at this one and ack if OK?
> 
> Looks fine to me.
> 
> Acked-by: Tero Kristo <t-kristo@ti.com>

OK thanks for checking, so from me too:

Acked-by: Tony Lindgren <tony@atomide.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij July 16, 2015, 12:36 p.m. UTC | #4
On Mon, Jul 6, 2015 at 5:11 PM, Grygorii Strashko
<grygorii.strashko@ti.com> wrote:

> On DRA7 there is one pinctrl domain (dra7_pmx_core) and
> PRCM wake-up IRQ is not shared, so remove quirk.
>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Patch applied with the ACKs.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 0b8d480..9b24b343 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1983,7 +1983,6 @@  static const struct pcs_soc_data pinctrl_single_omap_wkup = {
 };
 
 static const struct pcs_soc_data pinctrl_single_dra7 = {
-	.flags = PCS_QUIRK_SHARED_IRQ,
 	.irq_enable_mask = (1 << 24),	/* WAKEUPENABLE */
 	.irq_status_mask = (1 << 25),	/* WAKEUPEVENT */
 };