[1/1] DRM-vmwgfx: Deletion of an unnecessary check before the function call "vfree"
diff mbox

Message ID 559A35C9.8050201@users.sourceforge.net
State New
Headers show

Commit Message

SF Markus Elfring July 6, 2015, 8:01 a.m. UTC
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 6 Jul 2015 09:49:11 +0200

The vfree() function performs also input parameter validation.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

John Hunter July 8, 2015, 5:49 a.m. UTC | #1
On Mon, Jul 6, 2015 at 4:01 PM, SF Markus Elfring <
elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 6 Jul 2015 09:49:11 +0200
>
> The vfree() function performs also input parameter validation.
> Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>

Reviewed-by: Zhao Junwang <zhjwpku@gmail.com>

kfree will check that.

> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 654c8da..f718a6d 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -2292,9 +2292,7 @@ static int vmw_resize_cmd_bounce(struct
> vmw_sw_context *sw_context,
>                                    (sw_context->cmd_bounce_size >> 1));
>         }
>
> -       if (sw_context->cmd_bounce != NULL)
> -               vfree(sw_context->cmd_bounce);
> -
> +       vfree(sw_context->cmd_bounce);
>         sw_context->cmd_bounce = vmalloc(sw_context->cmd_bounce_size);
>
>         if (sw_context->cmd_bounce == NULL) {
> --
> 2.4.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
SF Markus Elfring July 8, 2015, 4:55 p.m. UTC | #2
> Reviewed-by: Zhao Junwang <zhjwpku@gmail.com> 
> 
> kfree will check that.

How does this feedback fit to a check before a call
of the vfree() function?

Regards,
Markus
John Hunter July 9, 2015, 12:08 a.m. UTC | #3
On Thu, Jul 9, 2015 at 12:55 AM, SF Markus Elfring <
elfring@users.sourceforge.net> wrote:

> > Reviewed-by: Zhao Junwang <zhjwpku@gmail.com>
> >
> > kfree will check that.
>
> How does this feedback fit to a check before a call
> of the vfree() function?
>
> I might have made a mistake, the ctl^] lead me to the vfree in mm/nommu.c,
there is also a vfree() function in mm/vmalloc.c.

Anyway, I think the catch is reasonable.


> Regards,
> Markus
>

Patch
diff mbox

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
index 654c8da..f718a6d 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -2292,9 +2292,7 @@  static int vmw_resize_cmd_bounce(struct vmw_sw_context *sw_context,
 				   (sw_context->cmd_bounce_size >> 1));
 	}
 
-	if (sw_context->cmd_bounce != NULL)
-		vfree(sw_context->cmd_bounce);
-
+	vfree(sw_context->cmd_bounce);
 	sw_context->cmd_bounce = vmalloc(sw_context->cmd_bounce_size);
 
 	if (sw_context->cmd_bounce == NULL) {