| Message ID | 1436350777-28056-6-git-send-email-rogerq@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 08, 2015 at 01:19:31PM +0300, Roger Quadros wrote: > The OTG core will use struct otg_hcd_ops to > add/remove the HCD controller. > > The main purpose of this interface is to avoid directly > calling usb_add/remove_hcd() from the OTG core as they > wouldn't be defined in the built-in symbol table if > CONFIG_USB is m. > Like patch 4, Would you let the OTG depends on HCD? OTG needs dual-role, it is reasonable. Peter > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > include/linux/usb/hcd.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h > index c9aa779..4108288 100644 > --- a/include/linux/usb/hcd.h > +++ b/include/linux/usb/hcd.h > @@ -386,6 +386,20 @@ struct hc_driver { > > }; > > +/** > + * struct otg_hcd_ops - Interface between OTG core and HCD > + * > + * Provided by the HCD core to allow the OTG core to start/stop the HCD > + * > + * @add: function to add the HCD > + * @remove: function to remove the HCD > + */ > +struct otg_hcd_ops { > + int (*add)(struct usb_hcd *hcd, > + unsigned int irqnum, unsigned long irqflags); > + void (*remove)(struct usb_hcd *hcd); > +}; > + > static inline int hcd_giveback_urb_in_bh(struct usb_hcd *hcd) > { > return hcd->driver->flags & HCD_BH; > -- > 2.1.4 >
On Wed, Jul 08, 2015 at 01:19:31PM +0300, Roger Quadros wrote: > The OTG core will use struct otg_hcd_ops to > add/remove the HCD controller. > > The main purpose of this interface is to avoid directly > calling usb_add/remove_hcd() from the OTG core as they > wouldn't be defined in the built-in symbol table if > CONFIG_USB is m. > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > include/linux/usb/hcd.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h > index c9aa779..4108288 100644 > --- a/include/linux/usb/hcd.h > +++ b/include/linux/usb/hcd.h > @@ -386,6 +386,20 @@ struct hc_driver { > > }; > > +/** > + * struct otg_hcd_ops - Interface between OTG core and HCD > + * > + * Provided by the HCD core to allow the OTG core to start/stop the HCD > + * > + * @add: function to add the HCD > + * @remove: function to remove the HCD > + */ > +struct otg_hcd_ops { > + int (*add)(struct usb_hcd *hcd, > + unsigned int irqnum, unsigned long irqflags); > + void (*remove)(struct usb_hcd *hcd); > +}; > + > static inline int hcd_giveback_urb_in_bh(struct usb_hcd *hcd) > { > return hcd->driver->flags & HCD_BH; > -- > 2.1.4 > Reviewed-by: Peter Chen <peter.chen@freescale.com>
diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h index c9aa779..4108288 100644 --- a/include/linux/usb/hcd.h +++ b/include/linux/usb/hcd.h @@ -386,6 +386,20 @@ struct hc_driver { }; +/** + * struct otg_hcd_ops - Interface between OTG core and HCD + * + * Provided by the HCD core to allow the OTG core to start/stop the HCD + * + * @add: function to add the HCD + * @remove: function to remove the HCD + */ +struct otg_hcd_ops { + int (*add)(struct usb_hcd *hcd, + unsigned int irqnum, unsigned long irqflags); + void (*remove)(struct usb_hcd *hcd); +}; + static inline int hcd_giveback_urb_in_bh(struct usb_hcd *hcd) { return hcd->driver->flags & HCD_BH;
The OTG core will use struct otg_hcd_ops to add/remove the HCD controller. The main purpose of this interface is to avoid directly calling usb_add/remove_hcd() from the OTG core as they wouldn't be defined in the built-in symbol table if CONFIG_USB is m. Signed-off-by: Roger Quadros <rogerq@ti.com> --- include/linux/usb/hcd.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+)