[RESEND] iio: adc: rockchip_saradc: add missing MODULE_* data
diff mbox

Message ID 8215730.uluDfnE1h7@diego
State New
Headers show

Commit Message

Heiko Stuebner July 8, 2015, 2:17 p.m. UTC
The module-data is currently missing. This includes the license-information
which makes the driver taint the kernel and miss symbols when compiled as
module.

Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/iio/adc/rockchip_saradc.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jonathan Cameron July 11, 2015, 5:32 p.m. UTC | #1
On 08/07/15 15:17, Heiko Stuebner wrote:
> The module-data is currently missing. This includes the license-information
> which makes the driver taint the kernel and miss symbols when compiled as
> module.
> 
> Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Sorry Heiko,

Not entirely sure why I haven't picked this up before.

Anyhow, now applied to the fixes-for-4.2 branch of iio.git
and marked for stable.  I need to catch up with a bit of a
backlog, but should get a pull request out to Greg sometime
early next week.

Jonathan
> ---
>  drivers/iio/adc/rockchip_saradc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 8d4e019..9c311c1 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -349,3 +349,7 @@ static struct platform_driver rockchip_saradc_driver = {
>  };
>  
>  module_platform_driver(rockchip_saradc_driver);
> +
> +MODULE_AUTHOR("Heiko Stuebner <heiko@sntech.de>");
> +MODULE_DESCRIPTION("Rockchip SARADC driver");
> +MODULE_LICENSE("GPL v2");
>
Heiko Stuebner July 11, 2015, 6:59 p.m. UTC | #2
Hi Jonathan,

Am Samstag, 11. Juli 2015, 18:32:42 schrieb Jonathan Cameron:
> On 08/07/15 15:17, Heiko Stuebner wrote:
> > The module-data is currently missing. This includes the
> > license-information
> > which makes the driver taint the kernel and miss symbols when compiled as
> > module.
> > 
> > Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> Sorry Heiko,
> 
> Not entirely sure why I haven't picked this up before.
> 
> Anyhow, now applied to the fixes-for-4.2 branch of iio.git
> and marked for stable.  I need to catch up with a bit of a
> backlog, but should get a pull request out to Greg sometime
> early next week.

really no problem. I track my patches and generally simply keep pestering 
people for as long as it takes ;-)

Heiko
Jonathan Cameron July 13, 2015, 9:23 a.m. UTC | #3
On 11 July 2015 19:59:31 BST, "Heiko Stübner" <heiko@sntech.de> wrote:
>Hi Jonathan,
>
>Am Samstag, 11. Juli 2015, 18:32:42 schrieb Jonathan Cameron:
>> On 08/07/15 15:17, Heiko Stuebner wrote:
>> > The module-data is currently missing. This includes the
>> > license-information
>> > which makes the driver taint the kernel and miss symbols when
>compiled as
>> > module.
>> > 
>> > Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>> 
>> Sorry Heiko,
>> 
>> Not entirely sure why I haven't picked this up before.
>> 
>> Anyhow, now applied to the fixes-for-4.2 branch of iio.git
>> and marked for stable.  I need to catch up with a bit of a
>> backlog, but should get a pull request out to Greg sometime
>> early next week.
>
>really no problem. I track my patches and generally simply keep
>pestering 
>people for as long as it takes ;-)
>
Very sensible!
>Heiko
Jonathan Cameron July 13, 2015, 8:52 p.m. UTC | #4
On 13/07/15 10:23, Jonathan Cameron wrote:
> 
> 
> On 11 July 2015 19:59:31 BST, "Heiko Stübner" <heiko@sntech.de> wrote:
>> Hi Jonathan,
>>
>> Am Samstag, 11. Juli 2015, 18:32:42 schrieb Jonathan Cameron:
>>> On 08/07/15 15:17, Heiko Stuebner wrote:
>>>> The module-data is currently missing. This includes the
>>>> license-information
>>>> which makes the driver taint the kernel and miss symbols when
>> compiled as
>>>> module.
>>>>
>>>> Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
>>>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>>>
>>> Sorry Heiko,
>>>
>>> Not entirely sure why I haven't picked this up before.
>>>
>>> Anyhow, now applied to the fixes-for-4.2 branch of iio.git
>>> and marked for stable.  I need to catch up with a bit of a
>>> backlog, but should get a pull request out to Greg sometime
>>> early next week.
>>
>> really no problem. I track my patches and generally simply keep
>> pestering 
>> people for as long as it takes ;-)
>>
> Very sensible!
In this case I was being a muppet.  Had two running fixes branches
(requests just sent for both of them) and I'd applied it to the other
one.  Hence when I got to the pull request it was in both of them.
Have dropped it from the post merge window one as it was fine in the
other.

Oops!
>> Heiko
>

Patch
diff mbox

diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
index 8d4e019..9c311c1 100644
--- a/drivers/iio/adc/rockchip_saradc.c
+++ b/drivers/iio/adc/rockchip_saradc.c
@@ -349,3 +349,7 @@  static struct platform_driver rockchip_saradc_driver = {
 };
 
 module_platform_driver(rockchip_saradc_driver);
+
+MODULE_AUTHOR("Heiko Stuebner <heiko@sntech.de>");
+MODULE_DESCRIPTION("Rockchip SARADC driver");
+MODULE_LICENSE("GPL v2");