diff mbox

[1/2] uxa: fix the call to PixmapSyncDirtyHelper, broken by xserver's 90db5ed

Message ID 1436430399-17198-1-git-send-email-martin.peres@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Martin Peres July 9, 2015, 8:26 a.m. UTC
Signed-off-by: Martin Peres <martin.peres@linux.intel.com>
---
 src/compat-api.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Chris Wilson July 9, 2015, 8:44 a.m. UTC | #1
On Thu, Jul 09, 2015 at 11:26:38AM +0300, Martin Peres wrote:
> Signed-off-by: Martin Peres <martin.peres@linux.intel.com>

I would prefer this to be testing for the unstable release that
introduces the ABI change (i.e. > rather than >=), but it fixes the
build from git today and you said you would follow through later if we
can be more precise.

Thanks,
-Chris
Dave Airlie July 9, 2015, 9:36 a.m. UTC | #2
Please just use

#ifdef HAS_DIRTYTRACKING_ROTATION

avoids the pain of versions.

Dave.

On 9 July 2015 at 18:44, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, Jul 09, 2015 at 11:26:38AM +0300, Martin Peres wrote:
>> Signed-off-by: Martin Peres <martin.peres@linux.intel.com>
>
> I would prefer this to be testing for the unstable release that
> introduces the ABI change (i.e. > rather than >=), but it fixes the
> build from git today and you said you would follow through later if we
> can be more precise.
>
> Thanks,
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Chris Wilson July 10, 2015, 9:24 a.m. UTC | #3
On Thu, Jul 09, 2015 at 07:36:16PM +1000, Dave Airlie wrote:
> Please just use
> 
> #ifdef HAS_DIRTYTRACKING_ROTATION
> 
> avoids the pain of versions.

Thanks, amended and pushed.
-Chris
diff mbox

Patch

diff --git a/src/compat-api.h b/src/compat-api.h
index aa93bee..1ca4380 100644
--- a/src/compat-api.h
+++ b/src/compat-api.h
@@ -247,3 +247,7 @@  static inline void FreePixmap(PixmapPtr pixmap)
 #endif
 
 #endif
+
+#if XORG_VERSION_CURRENT >= XORG_VERSION_NUMERIC(1,17,99,0,0)
+#define PixmapSyncDirtyHelper(d, dd) PixmapSyncDirtyHelper(d)
+#endif