diff mbox

drm/fourcc: Add formats R8, RG88, GR88

Message ID 1436431122-14489-1-git-send-email-chad.versace@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Chad Versace July 9, 2015, 8:38 a.m. UTC
The Kodi/XBMC developers want to transcode NV12 to RGB with OpenGL
shaders, importing the two source planes through
EGL_EXT_image_dma_buf_import. That requires importing the Y plane as an
R8 EGLImage and the UV plane as either an RG88 or GR88 EGLImage.

CC: Peter Frühberger <peter.fruehberger@gmail.com>
Cc: Rainer Hochecker <rainer.hochecker@onlinehome.de>
Cc: Benjamin Widawsky <benjamin.widawsky@intel.com>
Signed-off-by: Chad Versace <chad.versace@intel.com>
---

I recently sent a patch series to mesa-dev that uses these new formats:
    Subject: [PATCH 0/2] egl,i965: Support importing R8 and GR88 dma_bufs as textures
    Date: Thu, 9 Jul 2015 01:17:41 -0700


 include/uapi/drm/drm_fourcc.h | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Pekka Paalanen July 9, 2015, 1:08 p.m. UTC | #1
On Thu,  9 Jul 2015 01:38:42 -0700
Chad Versace <chad.versace@intel.com> wrote:

> The Kodi/XBMC developers want to transcode NV12 to RGB with OpenGL
> shaders, importing the two source planes through
> EGL_EXT_image_dma_buf_import. That requires importing the Y plane as an
> R8 EGLImage and the UV plane as either an RG88 or GR88 EGLImage.
> 
> CC: Peter Frühberger <peter.fruehberger@gmail.com>
> Cc: Rainer Hochecker <rainer.hochecker@onlinehome.de>
> Cc: Benjamin Widawsky <benjamin.widawsky@intel.com>
> Signed-off-by: Chad Versace <chad.versace@intel.com>
> ---
> 
> I recently sent a patch series to mesa-dev that uses these new formats:
>     Subject: [PATCH 0/2] egl,i965: Support importing R8 and GR88 dma_bufs as textures
>     Date: Thu, 9 Jul 2015 01:17:41 -0700
> 
> 
>  include/uapi/drm/drm_fourcc.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 2f295cd..8c5e8b9 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -34,6 +34,13 @@
>  /* color index */
>  #define DRM_FORMAT_C8		fourcc_code('C', '8', ' ', ' ') /* [7:0] C */
>  
> +/* 8 bpp Red */
> +#define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
> +
> +/* 16 bpp RG */
> +#define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
> +#define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
> +
>  /* 8 bpp RGB */
>  #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
>  #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */

Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>


Thanks,
pq
Daniel Vetter July 9, 2015, 1:13 p.m. UTC | #2
On Thu, Jul 09, 2015 at 04:08:08PM +0300, Pekka Paalanen wrote:
> On Thu,  9 Jul 2015 01:38:42 -0700
> Chad Versace <chad.versace@intel.com> wrote:
> 
> > The Kodi/XBMC developers want to transcode NV12 to RGB with OpenGL
> > shaders, importing the two source planes through
> > EGL_EXT_image_dma_buf_import. That requires importing the Y plane as an
> > R8 EGLImage and the UV plane as either an RG88 or GR88 EGLImage.
> > 
> > CC: Peter Frühberger <peter.fruehberger@gmail.com>
> > Cc: Rainer Hochecker <rainer.hochecker@onlinehome.de>
> > Cc: Benjamin Widawsky <benjamin.widawsky@intel.com>
> > Signed-off-by: Chad Versace <chad.versace@intel.com>
> > ---
> > 
> > I recently sent a patch series to mesa-dev that uses these new formats:
> >     Subject: [PATCH 0/2] egl,i965: Support importing R8 and GR88 dma_bufs as textures
> >     Date: Thu, 9 Jul 2015 01:17:41 -0700
> > 
> > 
> >  include/uapi/drm/drm_fourcc.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> > index 2f295cd..8c5e8b9 100644
> > --- a/include/uapi/drm/drm_fourcc.h
> > +++ b/include/uapi/drm/drm_fourcc.h
> > @@ -34,6 +34,13 @@
> >  /* color index */
> >  #define DRM_FORMAT_C8		fourcc_code('C', '8', ' ', ' ') /* [7:0] C */
> >  
> > +/* 8 bpp Red */
> > +#define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
> > +
> > +/* 16 bpp RG */
> > +#define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
> > +#define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
> > +
> >  /* 8 bpp RGB */
> >  #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
> >  #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
> 
> Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

Applied to topic/drm-misc, thanks.
-Daniel
> 
> 
> Thanks,
> pq
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index 2f295cd..8c5e8b9 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -34,6 +34,13 @@ 
 /* color index */
 #define DRM_FORMAT_C8		fourcc_code('C', '8', ' ', ' ') /* [7:0] C */
 
+/* 8 bpp Red */
+#define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
+
+/* 16 bpp RG */
+#define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
+#define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
+
 /* 8 bpp RGB */
 #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
 #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */