[2/2] ARM: OMAP2+: sparse: add missing function declarations
diff mbox

Message ID 3cb0fd46a493d80fad4d03316cdd6fb67a1938b7.1436622578.git.nsekhar@ti.com
State New
Headers show

Commit Message

Sekhar Nori July 11, 2015, 2:59 p.m. UTC
omap3xxx_restart() and omap44xx_restart() are global
functions declared in common.h. Include this file
in omap3-restart.c and omap4-restart.c to prevent
sparse warnings of type:

arch/arm/mach-omap2/omap4-restart.c:22:6: warning: symbol 'omap44xx_restart' was not declared. Should it be static?

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 arch/arm/mach-omap2/omap3-restart.c | 1 +
 arch/arm/mach-omap2/omap4-restart.c | 1 +
 2 files changed, 2 insertions(+)

Comments

Paul Walmsley July 16, 2015, 5:43 a.m. UTC | #1
On Sat, 11 Jul 2015, Sekhar Nori wrote:

> omap3xxx_restart() and omap44xx_restart() are global
> functions declared in common.h. Include this file
> in omap3-restart.c and omap4-restart.c to prevent
> sparse warnings of type:
> 
> arch/arm/mach-omap2/omap4-restart.c:22:6: warning: symbol 'omap44xx_restart' was not declared. Should it be static?
> 
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

Thanks, queued for v4.3.

- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/mach-omap2/omap3-restart.c b/arch/arm/mach-omap2/omap3-restart.c
index 103a49f68bcb..4bdd22edb96b 100644
--- a/arch/arm/mach-omap2/omap3-restart.c
+++ b/arch/arm/mach-omap2/omap3-restart.c
@@ -14,6 +14,7 @@ 
 #include <linux/init.h>
 #include <linux/reboot.h>
 
+#include "common.h"
 #include "control.h"
 #include "prm.h"
 
diff --git a/arch/arm/mach-omap2/omap4-restart.c b/arch/arm/mach-omap2/omap4-restart.c
index a99e7f7fb5be..e17136a50e27 100644
--- a/arch/arm/mach-omap2/omap4-restart.c
+++ b/arch/arm/mach-omap2/omap4-restart.c
@@ -9,6 +9,7 @@ 
 
 #include <linux/types.h>
 #include <linux/reboot.h>
+#include "common.h"
 #include "prm.h"
 
 /**