kernel BUG at fs/9p/acl.c:96! 4.1.1 bz #94531

Commit Message

Al Viro July 11, 2015, 6:55 p.m. UTC

On Wed, Jul 08, 2015 at 03:58:54PM +0200, Sverd Johnsen wrote:
> I filed this a few months ago and can still be reproduced easily with
> kernel 4.1.1:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=94531
> 
> [  224.248568] ------------[ cut here ]------------
> [  224.252792] kernel BUG at fs/9p/acl.c:96!

See if this fixes the sucker on your setup; it should've removed the
inode from hash, since leaving it there means that the next attempt
to look it up via iget5_locked() will just succeed, with no indication
of failed inode setup...

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c
index 09e4433..e8aa57d 100644
--- a/fs/9p/vfs_inode_dotl.c
+++ b/fs/9p/vfs_inode_dotl.c
@@ -149,8 +149,7 @@  static struct inode *v9fs_qid_iget_dotl(struct super_block *sb,
 	unlock_new_inode(inode);
 	return inode;
 error:
-	unlock_new_inode(inode);
-	iput(inode);
+	iget_failed(inode);
 	return ERR_PTR(retval);
 
 }