From patchwork Sun Jul 12 14:26:45 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 6772521 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CA5A39F2F0 for ; Sun, 12 Jul 2015 14:29:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E806E2066D for ; Sun, 12 Jul 2015 14:29:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12B352065E for ; Sun, 12 Jul 2015 14:29:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbbGLO3J (ORCPT ); Sun, 12 Jul 2015 10:29:09 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:36186 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbbGLO1G (ORCPT ); Sun, 12 Jul 2015 10:27:06 -0400 Received: by obdbs4 with SMTP id bs4so216058297obd.3; Sun, 12 Jul 2015 07:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=1CLdV/7/98dfRoCF0//xE+CAUUQJjiM3pLPaSDPs/E0=; b=K7upgxHECa1YsChRh7rMIXNP0MkJAAHHvGcJlj+0x7i1OWLZmIpn4zT3X3grtEFxmT O3MpGWjyIVSkppK4i+gsm2HtX/l3Iu22F8xLU7B+Wi50fgp5bWPZl2yFg9eXlFU/3YHn TgvSbAuJX45BM8mjy7mFXLhTWAyn7VAY6u59fwO1ujly1FY1pMwDP584A+/FyMkFPiJW f3trcBUlur1eztTx0U4KcL/E+FqnKt0TNRT1n067GAcv/Fnf6tab1KQc/LC7pLeTl7C8 nUAQjLn8PbtX+5iGd9js4s4e//LMKJ8Fta4YcVRKrK+fwc/OtviFGmGxmhseovGpkh0a NICg== X-Received: by 10.60.102.74 with SMTP id fm10mr8232302oeb.65.1436711225598; Sun, 12 Jul 2015 07:27:05 -0700 (PDT) Received: from rob-hp-laptop.herring.priv (72-48-98-129.dyn.grandenetworks.net. [72.48.98.129]) by smtp.googlemail.com with ESMTPSA id w8sm8090475oec.7.2015.07.12.07.27.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 12 Jul 2015 07:27:05 -0700 (PDT) From: Rob Herring To: linux-arm-kernel@lists.infradead.org, Russell King Cc: linux-kernel@vger.kernel.org, arm@kernel.org, Tony Lindgren , linux-omap@vger.kernel.org Subject: [PATCH v2 07/13] memory: kill off set_irq_flags usage Date: Sun, 12 Jul 2015 09:26:45 -0500 Message-Id: <1436711211-18223-8-git-send-email-robh@kernel.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1436711211-18223-1-git-send-email-robh@kernel.org> References: <1436711211-18223-1-git-send-email-robh@kernel.org> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP set_irq_flags is ARM specific with custom flags which have genirq equivalents. Convert drivers to use the genirq interfaces directly, so we can kill off set_irq_flags. The translation of flags is as follows: IRQF_VALID -> !IRQ_NOREQUEST IRQF_PROBE -> !IRQ_NOPROBE IRQF_NOAUTOEN -> IRQ_NOAUTOEN For IRQs managed by an irqdomain, the irqdomain core code handles clearing and setting IRQ_NOREQUEST already, so there is no need to do this in .map() functions and we can simply remove the set_irq_flags calls. Some users also set IRQ_NOPROBE and this has been maintained although it is not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Acked-by: Roger Quadros Cc: Tony Lindgren Cc: linux-omap@vger.kernel.org --- drivers/memory/omap-gpmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index 8911e51..dde6f4dd 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -1176,8 +1176,8 @@ static int gpmc_setup_irq(void) gpmc_client_irq[i].irq = gpmc_irq_start + i; irq_set_chip_and_handler(gpmc_client_irq[i].irq, &gpmc_irq_chip, handle_simple_irq); - set_irq_flags(gpmc_client_irq[i].irq, - IRQF_VALID | IRQF_NOAUTOEN); + irq_modify_status(gpmc_client_irq[i].irq, IRQ_NOREQUEST, + IRQ_NOAUTOEN); } /* Disable interrupts */ @@ -1200,7 +1200,6 @@ static int gpmc_free_irq(void) for (i = 0; i < GPMC_NR_IRQ; i++) { irq_set_handler(gpmc_client_irq[i].irq, NULL); irq_set_chip(gpmc_client_irq[i].irq, &no_irq_chip); - irq_modify_status(gpmc_client_irq[i].irq, 0, 0); } irq_free_descs(gpmc_irq_start, GPMC_NR_IRQ);