From patchwork Mon Jul 13 07:08:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christian_K=C3=B6nig?= X-Patchwork-Id: 6775751 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3E1509F380 for ; Mon, 13 Jul 2015 07:41:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5876E2056C for ; Mon, 13 Jul 2015 07:41:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id DB18020502 for ; Mon, 13 Jul 2015 07:41:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2835C6E774; Mon, 13 Jul 2015 00:41:18 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0139.outbound.protection.outlook.com [157.56.111.139]) by gabe.freedesktop.org (Postfix) with ESMTPS id 61A4C6E774 for ; Mon, 13 Jul 2015 00:41:17 -0700 (PDT) Received: from BY2PR02CA0090.namprd02.prod.outlook.com (10.242.32.48) by CY1PR02MB1151.namprd02.prod.outlook.com (10.163.15.153) with Microsoft SMTP Server (TLS) id 15.1.213.14; Mon, 13 Jul 2015 07:08:50 +0000 Received: from BY2FFO11FD015.protection.gbl (2a01:111:f400:7c0c::198) by BY2PR02CA0090.outlook.office365.com (2a01:111:e400:2c2a::48) with Microsoft SMTP Server (TLS) id 15.1.213.14 via Frontend Transport; Mon, 13 Jul 2015 07:08:50 +0000 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; codeaurora.org; dkim=none (message not signed) header.d=none; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from atltwp01.amd.com (165.204.84.221) by BY2FFO11FD015.mail.protection.outlook.com (10.1.14.131) with Microsoft SMTP Server id 15.1.213.8 via Frontend Transport; Mon, 13 Jul 2015 07:08:49 +0000 X-WSS-ID: 0NREZUO-07-N6H-02 X-M-MSG: Received: from satlvexedge01.amd.com (satlvexedge01.amd.com [10.177.96.28]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by atltwp01.amd.com (Axway MailGate 5.3.1) with ESMTPS id 24512CAE61C; Mon, 13 Jul 2015 03:08:48 -0400 (EDT) Received: from SATLEXDAG05.amd.com (10.181.40.11) by satlvexedge01.amd.com (10.177.96.28) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 13 Jul 2015 02:09:02 -0500 Received: from STOREXDAG02.amd.com (10.1.13.11) by satlexdag05.amd.com (10.181.40.11) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 13 Jul 2015 03:08:49 -0400 Received: from STOREXDAG04.amd.com ([fe80::bd56:e04f:8f2f:181c]) by storexdag02.amd.com ([fe80::58c9:5a5b:53f3:fb43%19]) with mapi id 14.03.0195.001; Mon, 13 Jul 2015 03:08:47 -0400 From: "Koenig, Christian" To: Archit Taneja Subject: Re: [RFC 14/21] drm/amdgpu: Remove FB_KMS_HELPER and FB related config options Thread-Topic: [RFC 14/21] drm/amdgpu: Remove FB_KMS_HELPER and FB related config options Thread-Index: AdC9OsKJ+vtGBcHZz0Wav9YGUBt8lg== Date: Mon, 13 Jul 2015 07:08:46 +0000 Message-ID: <38bd05d3-79ad-4dd5-8eb6-328ac0ac1ae8@email.android.com> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD015; 1:umfu1P7MwsYNzqL2RvSvly2gCZ1M5c05VtQKhwBFBxeoJKbTBFj26La7TcWTSKE3dzmz+WmU3x/dpP+FwY//kSGHDaJNQYj39Crsxc/OmKlZzt+9tuR/1uMJI4VWwMYJf4ccwoMN8kU2zm9s4uC/naC6YCjiiCAJlAfoPGvsmsCQ4uciiVV2mJiu2+dO297az1VH8+/xiIy3EyV8cmwszJA1ycrTSs61TtW+FZGUC2g4Z+YLeqHO1Xml4hznJnkzKAx9lKmdjtO7/Kf2kxxk3pMQSNJte+wdqPs6VjEcTchqaH9Jv6NtgRY8Rk4PI1su35S8ZqOIi2Ch/8U7OzkMkcoKDv++qlVS503exNEmepzqmtFoc8M+w1aU3uVx/6RT X-Forefront-Antispam-Report: CIP:165.204.84.221; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(428002)(199003)(189002)(46102003)(5001920100001)(101416001)(110136002)(189998001)(30436002)(84326002)(512874002)(2900100001)(54356999)(2656002)(19580405001)(102836002)(105586002)(87936001)(50986999)(31686004)(19580395003)(16236675004)(31696002)(53416004)(62966003)(86362001)(33646002)(5250100002)(92566002)(77156002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR02MB1151; H:atltwp01.amd.com; FPR:; SPF:None; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1151; 2:hUFePRKp0bonkbOM0EP1GQKFdDe7ByIdmn///WjnGMRCbPXQp2i8bGortUergXbj; 3:v4c6I9Ty/Poa09ljzoW0ijQRx0ytnAAjCnPLSQIEoQWHcpXdhuYXeCV4Vvuqgq3OdbY+W2Aj0ufFytlGMpWtkcho0kDgix8QC9/jfwNqmPjgUU7ylanAJc2KNhY2th4HWWidf+IW3vLDdcdhYdRWVzrqRZWe3ctYCHf4oEqgu3DgfzOrHfKZuWiVmxwPRRaUm9MA/4r5lMapHrH9zHeur2bTvNvGGkR2+wZHVoprho+8MhFJteJtczvwy7DkBMHk; 25:gRQnMY5MLyycZPi75AkX07PugOxDsyNOu8ZF+1rD4R4qmpzkIeScMIvS0qyzOufW0f8Z/qKidXF6gmDAdm47eWY1Z3HD7q+tKWvYei3ORI61MJ5psb6Ml2yEo5Kf1FMdwoFi8lJ1WOFZNc+NcQB0IkihtlxXMC6MMro5+sSsaZ7RG/Zy+KCAefv3Vaj9TxSmm+fnnZXkuFlseweRFtwDfFn3O3We+4t22apbhzkkUCfgBKqrIjHZYgl4g7hrq4MEcJsByrK1d6gjqvyx8q8WPg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR02MB1151; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1151; 20:3VyUmyQTP1uDJld/dtXYy9KQjTzVBNBJOkE8LRxouGGoBHPU3aDtRfjYQHt41GA5WsW04n50HAzMYCWiXCTTs2p5co7iDO0+LWT+fOzT7rfwnOdzBOlI6t/3UrVpgNmkYvK6m85IN+pe1a5aWFCh1QMJnfOq99lE4VK66Hlb69lQ2CBgh/Ea2d12Hl+55597bOa9yb8po//crsCNyGS3MPqk1pd8FNjmIra4CmoKdk/D3TSyivhuZDPwo4SyewWG9XwxQybJ39uAmSuvHvro5/6v+++kPWGx5gr5IEYMhuH0fecve+QPvmeT52aAr3hvGevLUtURvuy2shyyEjmk03TeAHSq2JJcbMw6MBtFr/ef1Fnmvp6VVb33WokuDIqc8qyupSfzdcGBuLg2loCGknLJBkOrqpMkRy9+s5jPhSU3t3eCtJa/LJOw87B+c1PmM7HX+cHLqNaJjYg6cTfYspXLCGhl0yE+0uYE4oivMQoJwQlksG+7h3JBbJHLDQTP; 4:9jWVMJHmFk70o3Pq/HoT9S30TOFP8RCS/HDw3U4JrTxwMeO80WqxPuhP4ZwkZz0m5DMomFkIQgzW0cilOM1GSQ37gpdld25Mhulz+SuWnRBSxkUFMkzdEe33OsP4pPeS63FDc2W+YtL/XdLrTWtKPMWO4xnYu0e3StxLKV1kNbXS6pmRfaoPnpruvmCFF9ukG/u7O+UW24t+Ccz5qaxQY4kb+u7IS0Zq6+K07j8l+aQ1tHd7zoyLtVlgGF9r3n84wzEw3nff0dxBsRDdHyBolaADk8KC5YxS0TsGG5Eljdo= CY1PR02MB1151: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:CY1PR02MB1151; BCL:0; PCL:0; RULEID:; SRVR:CY1PR02MB1151; X-Forefront-PRVS: 0636271852 X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1151; 23:BayaWqpn6ZZSZGh/3ZFTp3lbd8jWF/dioEJYdq2tfagFXdcAqRvSGWlnjuWdTMqeUalo42jrt6tyQ6G1uCK/fS2VJZ0QaRl9okbQSRHsdi7MRe8zqrIvbeNTq1Vio2Dp/MI1rnx1p/Ai/brhk7F4lX0kMHTIt5aDpShLBUPmLdTPg0XA24GiBCKmw9c3HOiMUTbPS/sVCsbEPjN+mZ0zGjEvhFBxH4GPBAeazUQkB2zOWADajR+hJE6+2jOpjWPOE2FxWUab62KWvBpswaBpNZ+bJlAy/wdqHeFIW8ZUA9+iwbDgW/8J3hhfsqzjEeyCadsDbJuIh1MhSj2CuBZg+8eYtNQ/HqSa/AR4u+rFu0niKEQc9o+g6v7NTdQsxeDo4VeDp9NnljFNd/Z6rKtal71akv6HEaojOMIG73ce9HA2Sb6iO24AAPOrQP96LT1mbyB+e0dbrn1GaUR111MZMFCuAB9gCpjtc+jojreLusHPbwiz8MapLyy9YlBHaOcMmWLoxpkCq2F+r+x9M14sPPT1n+QHwwGlj/Yibs4Nb3XlfsIdmAf15Wb2qCUfPMVxueAamD4GAEaN6dUYd2pIGI1baBIJIH8ykBVjaxSysRCscjO39yBtv3oR++R2TLSkJl+5blF6y04T2k1RE+mon9e6OGjhZqOHe4GTQ7lZOXs5xChhp/x9dAEWY673dEG5HGlHrgMuvRWMNWfDdvqBJw9ydkcdeIAIOWV9jCNHUmBVTk0MOUaPPuQHBQpk8etEBvJ8yK5YvdIqh2O2AsuKGjzQEKUy1gAFZ3p5O97rM6gOgloGkM5rEJHC7hhvD4duGnIS+2m40YwT6K35kIkKlq8hwVEcB3A5rZ+7ijbbHL8= X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1151; 5:LJqHWqlLL07pcu3iOKqFZTFTa7tnWCbo4wJ0nWkAcCSDqmBkQWS4lh3gr75x7cy0Uug3T4g/ELcTIqofy1lQ5XAc/GkdDiMBAOXENJEyRs8s13uYvoFwdr0tbV+4+kcBnWy3oOzlFOf0MRH+tv5QKA==; 24:XdcEPmic63pfMMA37hk3qPPfJyCdKTriOJQ6Wp5dY3lbwd33tbfMIP/Y+PysMAnXUneHtLTYrMPhN6nSUc3fXqvnZV5amN4UqUm2OCYA5sY=; 20:r/9pcYG1rbQe4qgcXGArmKHWadfpVPz8uB1hAoZK9bg2wJZFRso5wudaacH7KCr6o8sjHDBRh57Zwm+zm4wa6w== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2015 07:08:49.4770 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96; Ip=[165.204.84.221]; Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB1151 Cc: "linux-arm-msm@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Deucher, Alexander" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Jammy, I suggested to make the feature optional because of the unit test's. There we don't need this feature and actually want to test the kernel functionality. Regards, Christian. Am 13.07.2015 08:45 schrieb Archit Taneja : Remove FB_* config options since the driver doesn't call any fbdev functions directly. Remove FB_KMS_HELPER as this would now be selected by the top level FBDEV_EMULATION config option. If the fbdev emulation isn't selected, the drm_fb_helper functions will be stubbed out. Cc: Alex Deucher Cc: Oded Gabbay Cc: "Christian König" Signed-off-by: Archit Taneja --- drivers/gpu/drm/amd/amdgpu/Kconfig | 4 ---- 1 file changed, 4 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig index da7dcbf..2396482 100644 --- a/drivers/gpu/drm/amd/amdgpu/Kconfig +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig @@ -1,12 +1,8 @@ config DRM_AMDGPU tristate "AMD GPU" depends on DRM && PCI - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT select FW_LOADER select DRM_KMS_HELPER - select DRM_KMS_FB_HELPER select DRM_TTM select POWER_SUPPLY select HWMON