[3/3] Boosting OPP1 voltage level
diff mbox

Message ID EAF47CD23C76F840A9E7FCE10091EFAB02A40C1013@dbde02.ent.ti.com
State Superseded
Delegated to: Kevin Hilman
Headers show

Commit Message

Gupta, Ramesh Feb. 12, 2009, 9:18 a.m. UTC
From a0b8d146249e05465ff30cfd72592418c7a5da8d Mon Sep 17 00:00:00 2001
From: Ramesh Gupta G <grgupta@ti.com>
Date: Thu, 12 Feb 2009 03:03:18 +0530
Subject: [PATCH 3/3] Boosting OPP1 voltage level

some issues are observed like DSP sending SYS_ERROR
MMU Fault if operated in OPP1, Looks like drop in voltage
making DSP to crash, this patch boosts voltage level slightly
for stable DSP.

Signed-off-by: Ramesh Gupta G <grgupta@ti.com>

---
 arch/arm/mach-omap2/omap3-opp.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Kevin Hilman March 9, 2009, 7:11 p.m. UTC | #1
"Gupta, Ramesh" <grgupta@ti.com> writes:

> From a0b8d146249e05465ff30cfd72592418c7a5da8d Mon Sep 17 00:00:00 2001
> From: Ramesh Gupta G <grgupta@ti.com>
> Date: Thu, 12 Feb 2009 03:03:18 +0530
> Subject: [PATCH 3/3] Boosting OPP1 voltage level
>
> some issues are observed like DSP sending SYS_ERROR
> MMU Fault if operated in OPP1, Looks like drop in voltage
> making DSP to crash, this patch boosts voltage level slightly
> for stable DSP.
>

Ramesh,

Have you retested DSPBRIDGE with the current PM branch HEAD?  Rajendra
submitted some patches that update VDD1 that are now included.  I'm
guessing that will fix the problems you've been seeing as well.

Kevin

>
> ---
>  arch/arm/mach-omap2/omap3-opp.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap3-opp.h b/arch/arm/mach-omap2/omap3-opp.h
> index 5540e5b..3b7fff6 100644
> --- a/arch/arm/mach-omap2/omap3-opp.h
> +++ b/arch/arm/mach-omap2/omap3-opp.h
> @@ -24,7 +24,7 @@
>  static struct omap_opp omap3_mpu_rate_table[] = {
>  	{0, 0, 0},
>  	/*OPP1*/
> -	{S125M, VDD1_OPP1, 0x18},
> +	{S125M, VDD1_OPP1, 0x1C},
>  	/*OPP2*/
>  	{S250M, VDD1_OPP2, 0x20},
>  	/*OPP3*/
> @@ -48,7 +48,7 @@ static struct omap_opp omap3_l3_rate_table[] = {
>  static struct omap_opp omap3_dsp_rate_table[] = {
>  	{0, 0, 0},
>  	/*OPP1*/
> -	{S90M, VDD1_OPP1, 0x18},
> +	{S90M, VDD1_OPP1, 0x1C},
>  	/*OPP2*/
>  	{S180M, VDD1_OPP2, 0x20},
>  	/*OPP3*/
> -- 
> 1.5.3.2
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Gupta, Ramesh March 10, 2009, 3:47 a.m. UTC | #2
Hi Kevin,
 

> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@deeprootsystems.com] 
> Sent: Tuesday, March 10, 2009 12:41 AM
> To: Gupta, Ramesh
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH 3/3] Boosting OPP1 voltage level
> 
> "Gupta, Ramesh" <grgupta@ti.com> writes:
> 
> > From a0b8d146249e05465ff30cfd72592418c7a5da8d Mon Sep 17 
> 00:00:00 2001
> > From: Ramesh Gupta G <grgupta@ti.com>
> > Date: Thu, 12 Feb 2009 03:03:18 +0530
> > Subject: [PATCH 3/3] Boosting OPP1 voltage level
> >
> > some issues are observed like DSP sending SYS_ERROR MMU Fault if 
> > operated in OPP1, Looks like drop in voltage making DSP to 
> crash, this 
> > patch boosts voltage level slightly for stable DSP.
> >
> 
> Ramesh,
> 
> Have you retested DSPBRIDGE with the current PM branch HEAD?  
> Rajendra submitted some patches that update VDD1 that are now 
> included.  I'm guessing that will fix the problems you've 
> been seeing as well.

I had tested with Rajendra patches with latest VDD1 voltage levels that resolved 
the issues I was seeing, I sent an updated patch set for DSP bridge DVFS and OFF mode support.

[PATCH 0/1] DSPBRIDGE DVFS and offmode support updated

Ref: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg09655.html

This patch "[PATCH 3/3] Boosting OPP1 voltage level" is not required any more.

Please let me know your comments.

Regards
Ramesh Gupta G
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/mach-omap2/omap3-opp.h b/arch/arm/mach-omap2/omap3-opp.h
index 5540e5b..3b7fff6 100644
--- a/arch/arm/mach-omap2/omap3-opp.h
+++ b/arch/arm/mach-omap2/omap3-opp.h
@@ -24,7 +24,7 @@ 
 static struct omap_opp omap3_mpu_rate_table[] = {
 	{0, 0, 0},
 	/*OPP1*/
-	{S125M, VDD1_OPP1, 0x18},
+	{S125M, VDD1_OPP1, 0x1C},
 	/*OPP2*/
 	{S250M, VDD1_OPP2, 0x20},
 	/*OPP3*/
@@ -48,7 +48,7 @@  static struct omap_opp omap3_l3_rate_table[] = {
 static struct omap_opp omap3_dsp_rate_table[] = {
 	{0, 0, 0},
 	/*OPP1*/
-	{S90M, VDD1_OPP1, 0x18},
+	{S90M, VDD1_OPP1, 0x1C},
 	/*OPP2*/
 	{S180M, VDD1_OPP2, 0x20},
 	/*OPP3*/