| Message ID | 1437139923-20153-1-git-send-email-marcandre.lureau@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Note: RFC must come within []. On Fri, Jul 17, 2015 at 03:32:03PM +0200, Marc-André Lureau wrote: > While reviewing vhost log code, I found out that log_file is never > set. Note: I haven't tested the change (QEMU doesn't use LOG_FD yet). > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > drivers/vhost/vhost.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index 2ee2826..fa49d329 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -886,6 +886,7 @@ long vhost_dev_ioctl(struct vhost_dev *d, unsigned int ioctl, void __user *argp) > } > if (eventfp != d->log_file) { > filep = d->log_file; > + d->log_file = eventfp; > ctx = d->log_ctx; > d->log_ctx = eventfp ? > eventfd_ctx_fileget(eventfp) : NULL; I've applied this, moving this a bit down. > -- > 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 2ee2826..fa49d329 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -886,6 +886,7 @@ long vhost_dev_ioctl(struct vhost_dev *d, unsigned int ioctl, void __user *argp) } if (eventfp != d->log_file) { filep = d->log_file; + d->log_file = eventfp; ctx = d->log_ctx; d->log_ctx = eventfp ? eventfd_ctx_fileget(eventfp) : NULL;
While reviewing vhost log code, I found out that log_file is never set. Note: I haven't tested the change (QEMU doesn't use LOG_FD yet). Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- drivers/vhost/vhost.c | 1 + 1 file changed, 1 insertion(+)