| Message ID | 1437147514.1229.1.camel@ingics.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dd9283e23f674281c02cd8cbf894cb3132a4e3a6 |
| Headers | show |
On Fri, 17 Jul 2015, Axel Lin wrote: > The max_register should be the maximum valid register index rather than > number of registers. Also remove unused defines. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > sound/soc/codecs/cs4349.c | 2 +- > sound/soc/codecs/cs4349.h | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-) > For both patches Thank you! Acked-by: Tim Howe <tim.howe@cirrus.com>
diff --git a/sound/soc/codecs/cs4349.c b/sound/soc/codecs/cs4349.c index a8df8a74..9273b06 100644 --- a/sound/soc/codecs/cs4349.c +++ b/sound/soc/codecs/cs4349.c @@ -268,7 +268,7 @@ static struct regmap_config cs4349_regmap = { .reg_bits = 8, .val_bits = 8, - .max_register = CS4349_NUMREGS, + .max_register = CS4349_MISC, .reg_defaults = cs4349_reg_defaults, .num_reg_defaults = ARRAY_SIZE(cs4349_reg_defaults), .readable_reg = cs4349_readable_register, diff --git a/sound/soc/codecs/cs4349.h b/sound/soc/codecs/cs4349.h index 3884a89..7effa0a 100644 --- a/sound/soc/codecs/cs4349.h +++ b/sound/soc/codecs/cs4349.h @@ -36,9 +36,6 @@ struct cs4349_platform_data { #define CS4349_RMPFLT 0x07 /* Ramp and Filter Control */ #define CS4349_MISC 0x08 /* Power Down,Freeze Control,Pop Stop*/ -#define CS4349_FIRSTREG 0x01 -#define CS4349_LASTREG 0x08 -#define CS4349_NUMREGS (CS4349_LASTREG - CS4349_FIRSTREG + 1) #define CS4349_I2C_INCR 0x80
The max_register should be the maximum valid register index rather than number of registers. Also remove unused defines. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- sound/soc/codecs/cs4349.c | 2 +- sound/soc/codecs/cs4349.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-)