| Message ID | 1437409187-7039-1-git-send-email-joakim.tjernlund@transmode.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 20 July 2015 at 18:19, Joakim Tjernlund <joakim.tjernlund@transmode.se> wrote: > Support for 8BIT bus with was added some time ago to sdhci-esdhc but > then missed to remove the 8BIT from the reserved bit mask which made > 8BIT non functional. > > Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se> Should this be queued as a fix then? If so, please resend and include a fixes tag. Kind regards Uffe > --- > drivers/mmc/host/sdhci-esdhc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h > index 3497cfa..a870c42 100644 > --- a/drivers/mmc/host/sdhci-esdhc.h > +++ b/drivers/mmc/host/sdhci-esdhc.h > @@ -45,6 +45,6 @@ > #define ESDHC_DMA_SYSCTL 0x40c > #define ESDHC_DMA_SNOOP 0x00000040 > > -#define ESDHC_HOST_CONTROL_RES 0x05 > +#define ESDHC_HOST_CONTROL_RES 0x01 > > #endif /* _DRIVERS_MMC_SDHCI_ESDHC_H */ > -- > 2.3.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2015-07-22 at 14:18 +0200, Ulf Hansson wrote: > On 20 July 2015 at 18:19, Joakim Tjernlund > <joakim.tjernlund@transmode.se> wrote: > > Support for 8BIT bus with was added some time ago to sdhci-esdhc but > > then missed to remove the 8BIT from the reserved bit mask which made > > 8BIT non functional. > > > > Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se> > > Should this be queued as a fix then? If so, please resend and include > a fixes tag. 8BIT never worked for this controller, when support for 8BIT was added no one noticed that it didn't work for sdhci-esdhc. I suspect it was never tested. If that qualifies as a fix I can add an: Fixes: 66b50a00992d ("mmc: esdhc: Add support for 8-bit bus width and non-removable card") > > Kind regards > Uffe > > > --- > > drivers/mmc/host/sdhci-esdhc.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h > > index 3497cfa..a870c42 100644 > > --- a/drivers/mmc/host/sdhci-esdhc.h > > +++ b/drivers/mmc/host/sdhci-esdhc.h > > @@ -45,6 +45,6 @@ > > #define ESDHC_DMA_SYSCTL 0x40c > > #define ESDHC_DMA_SNOOP 0x00000040 > > > > -#define ESDHC_HOST_CONTROL_RES 0x05 > > +#define ESDHC_HOST_CONTROL_RES 0x01 > > > > #endif /* _DRIVERS_MMC_SDHCI_ESDHC_H */ > > -- > > 2.3.6 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h index 3497cfa..a870c42 100644 --- a/drivers/mmc/host/sdhci-esdhc.h +++ b/drivers/mmc/host/sdhci-esdhc.h @@ -45,6 +45,6 @@ #define ESDHC_DMA_SYSCTL 0x40c #define ESDHC_DMA_SNOOP 0x00000040 -#define ESDHC_HOST_CONTROL_RES 0x05 +#define ESDHC_HOST_CONTROL_RES 0x01 #endif /* _DRIVERS_MMC_SDHCI_ESDHC_H */
Support for 8BIT bus with was added some time ago to sdhci-esdhc but then missed to remove the 8BIT from the reserved bit mask which made 8BIT non functional. Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se> --- drivers/mmc/host/sdhci-esdhc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)